Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define permissions policy within the worklet #420

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Define permissions policy within the worklet #420

wants to merge 1 commit into from

Conversation

xyaoinum
Copy link
Contributor

No description provided.

aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 11, 2023
@yaoxiachromium
[FLEDGE] implement the private-aggregation permissions policy check
afe8f9c 
When LoadBidderWorklet()/LoadSellerWorklet(), calculate and pass
in the permissions policy state to the worklet environment: get each
policy's enabled state by calling
rfh->permissions_policy()->IsFeatureEnabledForOrigin() against
the script (worklet) origin.

Explainer PR: WICG/turtledove#420

Bug: 1403364
Change-Id: I85577d8d67850c739526222609a4415a78ce248a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4133845
Reviewed-by: Qingxin Wu <qingxinwu@google.com>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1091383}
aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 11, 2023
@Tanych
Revert "[FLEDGE] implement the private-aggregation permissions policy…
7300daf 
… check"

This reverts commit afe8f9c.

Reason for revert: cause build failed on https://ci.chromium.org/ui/p/chromium/builders/ci/Win%20x64%20Builder/129351/overview

Original change's description:
> [FLEDGE] implement the private-aggregation permissions policy check
>
> When LoadBidderWorklet()/LoadSellerWorklet(), calculate and pass
> in the permissions policy state to the worklet environment: get each
> policy's enabled state by calling
> rfh->permissions_policy()->IsFeatureEnabledForOrigin() against
> the script (worklet) origin.
>
> Explainer PR: WICG/turtledove#420
>
> Bug: 1403364
> Change-Id: I85577d8d67850c739526222609a4415a78ce248a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4133845
> Reviewed-by: Qingxin Wu <qingxinwu@google.com>
> Commit-Queue: Yao Xiao <yaoxia@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1091383}

Bug: 1403364
Change-Id: I4eaab3e4482df74bc797f75956cecc45c91e8215
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4157692
Commit-Queue: Victor Tan <victortan@chromium.org>
Owners-Override: Jonathan Ross <jonross@google.com>
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1091408}
aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 12, 2023
@yaoxiachromium
Reland "[FLEDGE] implement the private-aggregation permissions policy…
70b9818 
… check"

This is a reland of commit afe8f9c

Original change's description:
> [FLEDGE] implement the private-aggregation permissions policy check
>
> When LoadBidderWorklet()/LoadSellerWorklet(), calculate and pass
> in the permissions policy state to the worklet environment: get each
> policy's enabled state by calling
> rfh->permissions_policy()->IsFeatureEnabledForOrigin() against
> the script (worklet) origin.
>
> Explainer PR: WICG/turtledove#420
>
> Bug: 1403364
> Change-Id: I85577d8d67850c739526222609a4415a78ce248a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4133845
> Reviewed-by: Qingxin Wu <qingxinwu@google.com>
> Commit-Queue: Yao Xiao <yaoxia@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1091383}

Bug: 1403364
Change-Id: I3dafea9031001438773642c575640bdc542e8cd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4157177
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Qingxin Wu <qingxinwu@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1091592}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@xyaoinum