-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API changes to make FLEDGE understand ad sizes #417
Merged
Merged
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
1a2368f
Update generateBid()
gtanzer ff42d5b
Most of joinAdInterestGroup changes
gtanzer d63d8e1
Expand description of joinAdInterestGroup fields
gtanzer 8851afc
Add runAdAuction requestedSize field
gtanzer d662fb7
Update generateBid description
gtanzer 038f2ca
Update FLEDGE.md
gtanzer 7791d78
Update FLEDGE.md
gtanzer 397e544
Update k-anon check
gtanzer 19c08f5
Update FLEDGE.md
gtanzer bbc82b5
Describe size macros
gtanzer 0251bbc
Update Release_Notes.md
gtanzer 3ef5be6
Fix typo
gtanzer fc9653f
Describe how size returned from generateBid is used
gtanzer 01ef829
Remove mention of filtering
gtanzer a0a310d
Describe purpose of sizes in interest group declaration
gtanzer 1ddddee
Update Release_Notes.md
gtanzer d642777
Update Release_Notes.md
gtanzer f25854c
Update Release_Notes.md
gtanzer d119ceb
Merge branch 'main' into patch-3
JensenPaul 5380368
Accept `sizeGroups` suggestion
gtanzer d102fbc
Accept suggestion
gtanzer 47d50e6
Accept suggestion to use group1 and group2 in ad size example
gtanzer 568873a
Accept suggestion to explicitly call out the "size3" example size->si…
gtanzer 0a3db48
Accept suggestion to call out AD_WIDTH and AD_HEIGHT explicitly in "s…
gtanzer adf4cbc
Accept suggestion to turn "url+size" into "URL and size"
gtanzer cb668e8
Accept suggestion to rephrase interest group size declaration descrip…
gtanzer 733a821
Mention optionality of interest group size fields
gtanzer 3ec71ac
Remark that sizes are also optional in generateBid
gtanzer cfbcb70
Add more (optionally)s
gtanzer 7c6aa0e
Update Release_Notes.md
gtanzer 85c2f60
Add more optionality
gtanzer 1e07855
Add more optionality
gtanzer c1e00cf
Update FLEDGE.md
gtanzer 2d44dd9
Update FLEDGE.md
gtanzer 7625240
Update FLEDGE.md
gtanzer 9ecc5f6
Update FLEDGE.md
gtanzer 4efd2e8
Update FLEDGE.md
gtanzer 064841f
Update FLEDGE.md
gtanzer 8199508
Update FLEDGE.md
gtanzer 81a8bf9
Update FLEDGE.md
gtanzer 7b856f7
Update FLEDGE.md
gtanzer 0cc20cb
Update Release_Notes.md
gtanzer 21795b9
Update requestedSize description
gtanzer ed3b830
Update browser signals
gtanzer cd73790
Update FLEDGE.md
gtanzer 06ace19
Change M115 to M116 for browser signals additions
gtanzer ca80dd8
Fix "bid" -> "auction config"
gtanzer 910a9f2
Remove renderSize from reportResult signals
gtanzer 3170266
Merge branch 'main' into patch-3
gtanzer b65b04a
Update FLEDGE.md
gtanzer 4d4364b
Update FLEDGE.md
gtanzer 6e6ec85
Update FLEDGE.md
gtanzer 975e965
Fix rebase issue
gtanzer c3fad7a
Add extra macro format
gtanzer cce7780
Fix {size: ...}
gtanzer 3e34e0d
Merge branch 'main' into patch-3
gtanzer a3662d5
Add explicit transition period
gtanzer d69f233
Add explicit transition period
gtanzer 2d3f228
Add explicit transition period
gtanzer a57adbe
Update FLEDGE.md
JensenPaul 7148d74
Fix link and perens.
JensenPaul f8cd3f6
Update FLEDGE.md
JensenPaul 50893b4
add missing space
JensenPaul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove mention of filtering
- Loading branch information
commit 01ef829bb59caede235a0ee2ec1c51e01830b258
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be helpful to describe more explicitly how these sizes would be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some description of this immediately below, namely: