-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spec] Real time reporting #1212
base: main
Are you sure you want to change the base?
Conversation
@morlovich Mind taking a look at this big PR? No need to review it all at once, we can go several rounds, whichever way you prefer. |
:: |bucket| | ||
: [=real time reporting contribution/priority weight=] | ||
:: [=platform contribution priority weight=] | ||
1. [=Insert entries to map=] given |realTimeContributionsMap|, |origin|, and « |contribution| » . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little confused by the typing of the 3rd argument here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a [=list=] literal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Maks! @domfarolino PTAL. Thanks! |
I honestly do not think I will have time to review this PR. It's pretty big and seems pretty complicated, and I am out of the office for a lot of July. One thing I will warn against though is fetching with no-cors. Now that we've already documented, in this spec, that it is bad and should be avoided, I think we should do whatever we can to ensure new requests are not doing that in both our implementation and spec. I'm hopeful we don't do that in the implementation. Separately, I would encourage you to audit the members of the request like origin/client and so on. I noticed a request made by this PR doesn't set a client, and doesn't set an origin. This is invalid for Fetch, and will blow up. What are we doing implementation-wise? And can we avoid no-cors by setting an appropriate origin? |
|
Also, I totally agree that this PR is quite large and complicated, and it's impossible to review everything without knowing the design/implementation details of the API. Fortunately Maks reviewed most of my CLs related to this new feature, and did a full review of this PR. One question about spec: is it common or useful to link to explainer? For example, we have a full explainer for this feature, explaining everything with more details. Is it useful to link to it in the spec in the new real time reporting section? |
Spec real time reporting.
Explainer: https://github.com/WICG/turtledove/blob/main/PA_real_time_monitoring.md
Also fixed a bug in the spec:
[=generate potentially multiple bids=] should return failure if fetching wasm failed.
Preview | Diff