Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify support for cross-origin trusted signals #1197

Merged
merged 14 commits into from
Jul 11, 2024

Conversation

morlovich
Copy link
Collaborator

@morlovich morlovich commented Jun 6, 2024

and the bundled queryFeatureSupport('*'). This also includes fixes to some bugs in parsing of these URLs (some of the checks were missing).

See #813 for more context.


Preview | Diff

and the bundled queryFeatureSupport('*'). This also includes
fixes to some bugs in parsing of these URLs (some of the
checks were missing).
@morlovich morlovich requested a review from qingxinwu June 6, 2024 14:00
@qingxinwu
Copy link
Collaborator

just a heads up, I may not have time to review it this week, but will find some time early next week

@qingxinwu qingxinwu added the spec Relates to the spec label Jun 10, 2024
Copy link
Collaborator

@qingxinwu qingxinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went through most of the PR. Will take a closer look at some places later.

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@morlovich morlovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...Doing the easy stuff first.

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
Copy link
Collaborator

@qingxinwu qingxinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there

spec.bs Outdated
@@ -4591,6 +4572,33 @@ The <dfn for="interest group">estimated size</dfn> of an [=interest group=] |ig|
1. Return the [=URL serializer|serialization=] of |url|.
</div>

<div algorithm>
To <dfn>parse and verify a bidding code or update URL</dfn> given a [=string=] |input| and a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To <dfn>parse and verify a bidding code or update URL</dfn> given a [=string=] |input| and a
To <dfn>parse and verify a bidding script or update URL</dfn> given a [=string=] |input| and an
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's using "code" since it includes WASM and not just javascript

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, it's not obvious what "code" means, but don't have a better suggestion.

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
@domfarolino domfarolino changed the title Specify support for cross-origin trusted signals, Jun 27, 2024
spec.bs Show resolved Hide resolved
Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working through the reviews here. I'm happy with this now that morlovich#3 and morlovich#4 are pretty much in place and ready to fast-follow this work here.

Please make sure to reference those in any relevant shipping documents (i.e., Blink launch process artifacts) as fast-follow work that will close some of the gaps that this PR introduces, so relevant approvers (i.e., API OWNERs) can get a full sense of what is going on and what is left. But from a spec perspective, I am supportive of landing this now that those follow-ups are nearly in place!

spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Show resolved Hide resolved
michaelkleber pushed a commit that referenced this pull request Jul 11, 2024
@michaelkleber michaelkleber merged commit 585f660 into WICG:main Jul 11, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Jul 11, 2024
SHA: 585f660
Reason: push, by michaelkleber

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to morlovich/turtledove that referenced this pull request Jul 11, 2024
SHA: 585f660
Reason: push, by morlovich

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec Relates to the spec
5 participants