-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update icons to use UnifiedIcon
#991
Conversation
src/Themes/NexusMods.Themes.NexusFluentDark/Styles/Controls/Icons/IconsStyles.axaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that there are still a lot of icons:Icon
around, specifically inside buttons.
I think we need those ported over and the button styles updated to use UnifiedIcon
instead of icons:Icon
Apart from that I think there might be broken due to the FontSize vs Size thing.
Game Widget had an Icon on the Add Game button that I think was broken even before this PR and needs updating.
I see them now. I was updating the files by searching for the Projektanker namespace, but apparently some files are using
A lot of icons didn't have sizes set before, and I didn't want to touch the styling. I changed |
Hmm, I'm worried we might have issues if we put something that isn't a projektanker icon in the ones that don't have a size and suddenly break the UI with too big or to small icons. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #991 +/- ##
==========================================
+ Coverage 58.18% 58.36% +0.18%
==========================================
Files 637 637
Lines 20564 20562 -2
Branches 1572 1571 -1
==========================================
+ Hits 11966 12002 +36
+ Misses 8240 8201 -39
- Partials 358 359 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
We shouldn't rely on implicit default sizes of Projektanker icons anyway. |
e38f045
to
8d2f65c
Compare
Resolves #979.