-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagnostics using source generator #975
Conversation
1ab6978
to
45e000b
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
==========================================
- Coverage 58.18% 57.93% -0.25%
==========================================
Files 637 644 +7
Lines 20564 21058 +494
Branches 1572 1642 +70
==========================================
+ Hits 11966 12201 +235
- Misses 8240 8467 +227
- Partials 358 390 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be merged for now with the Caveat of the things we discussed in call before.
Mainly allowing the definition of custom link handlers rather than just having a limited set of operations to do.
Diagnostics can now be created using a template builder:
This will generate the following method and struct:
This generator isn't complete yet, and this PR is only to get started with some basic source generation. I'm going to create an epic to go over some future features of our diagnostic system.