-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial Apply UI implementation #973
Conversation
- Implemented Apply functionality on button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
Add scheduler to ToProperty use .Equals
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
=========================================
+ Coverage 0 58.18% +58.18%
=========================================
Files 0 637 +637
Lines 0 20520 +20520
Branches 0 1572 +1572
=========================================
+ Hits 0 11939 +11939
- Misses 0 8217 +8217
- Partials 0 364 +364
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Run Apply on taskpool
This PR adds an initial quite rough Apply button implementation.
ApplyService
to be used later to queue Apply operations and ensure only one loadout is being applied to a game at a time.ApplyControlView
that contains the Apply and Launch buttons.So for now the Apply button shows up after the user makes at least one new Loadout revision since starting the app.
Pressing the button Applies the loadout while showing a spinner and hiding the Launch button.
After applying is done the button is hidden waiting for new loadout changes.
Limitations of this PR:
All of these limitations should be handled after event sourcing has been integrated, together with #871