Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save and restore last window session #954

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Save and restore last window session #954

merged 4 commits into from
Feb 19, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Feb 15, 2024

Resolves #907.
@erri120 erri120 added Design UI/UX This is related to the UI. Epic: Workspace System This is related to the Panels/Workspace system labels Feb 15, 2024
@erri120 erri120 added this to the v0.4 milestone Feb 15, 2024
@erri120 erri120 requested a review from a team February 15, 2024 12:57
@erri120 erri120 self-assigned this Feb 15, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (d6e79c9) 58.54% compared to head (46b7526) 58.47%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #954      +/-   ##
==========================================
- Coverage   58.54%   58.47%   -0.08%     
==========================================
  Files         626      631       +5     
  Lines       20177    20350     +173     
  Branches     1551     1562      +11     
==========================================
+ Hits        11812    11899      +87     
- Misses       8007     8084      +77     
- Partials      358      367       +9
Flag Coverage Δ
Linux 57.84% <28.44%> (-0.04%) ⬇️
Windows 57.77% <28.44%> (-0.03%) ⬇️
clean_environment_tests 58.46% <28.44%> (-0.07%) ⬇️
networking_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/NexusMods.App.UI/Services.cs 98.49% <100.00%> (+0.04%) ⬆️
src/NexusMods.App.UI/TypeFinder.cs 100.00% <100.00%> (ø)
...App.UI/WorkspaceSystem/Context/DownloadsContext.cs 0.00% <ø> (ø)
...ods.App.UI/WorkspaceSystem/Context/EmptyContext.cs 50.00% <ø> (ø)
...Mods.App.UI/WorkspaceSystem/Context/HomeContext.cs 0.00% <ø> (ø)
...Mods.App.UI/Controls/Spine/SpineDesignViewModel.cs 0.00% <0.00%> (ø)
...rc/NexusMods.App.UI/Windows/DesignWindowManager.cs 20.00% <0.00%> (-3.08%) ⬇️
...s.App.UI/WorkspaceSystem/Context/LoadoutContext.cs 0.00% <0.00%> (ø)
....App.UI/WorkspaceSystem/DataStore/WorkspaceData.cs 0.00% <0.00%> (ø)
...UI/WorkspaceSystem/Workspace/WorkspaceViewModel.cs 48.56% <0.00%> (-0.13%) ⬇️
... and 6 more

... and 18 files with indirect coverage changes
@erri120
Copy link
Member Author

erri120 commented Feb 15, 2024

TODO: exclude "new tab"-tab from serialization.
Al12rs
Al12rs requested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@Al12rs Al12rs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Save NewTabs as well, currently their context isn't serializable
@erri120 erri120 force-pushed the feat/907-save-restore-workspace branch from 681cef2 to a5f7472 Compare February 19, 2024 09:24
@erri120 erri120 merged commit d2ce293 into Nexus-Mods:main Feb 19, 2024
6 checks passed
@erri120 erri120 deleted the feat/907-save-restore-workspace branch February 19, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design UI/UX This is related to the UI. Epic: Workspace System This is related to the Panels/Workspace system
3 participants
@erri120 @codecov-commenter @Al12rs