Simplify crating IconValue
s for UnifiedIcon
from XAML
#953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the various existing Setters on
IconValue
to be easier to use from XAML.They now take the original types of
string
,IImage
,Geometry
instead of the custom types used internally byIconValue
.This allows them to be set them inline instead of having to wrap them in the custom types.
This maintains the single
UnifiedIcon.Value
Api, but reduces the number of lines needed to define the contents of an icon from XAML.Before:
After: