Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implicit conversion for OpenPageBehvaior entries #951

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Feb 15, 2024

  • This avoids having to explicitly wrap the actual behavior with the OpenPageBehavior container when passing it, avoiding the awkward double new

Should make lines more concise and clearer to read

- This avoids having to wrap each record in a new `OpenPageBehvaior` when passing it
@Al12rs Al12rs requested a review from a team February 15, 2024 11:10
@Al12rs Al12rs self-assigned this Feb 15, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (903e6fb) 58.67% compared to head (c5f3f3b) 58.65%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #951      +/-   ##
==========================================
- Coverage   58.67%   58.65%   -0.03%     
==========================================
  Files         630      630              
  Lines       20253    20256       +3     
  Branches     1555     1555              
==========================================
- Hits        11884    11881       -3     
- Misses       8006     8015       +9     
+ Partials      363      360       -3     
Flag Coverage Δ
Linux 58.02% <0.00%> (-0.01%) ⬇️
Windows 57.93% <0.00%> (-0.03%) ⬇️
clean_environment_tests 58.64% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...WorkspaceSystem/Controllers/WorkspaceController.cs 48.25% <0.00%> (ø)
.../WorkspaceSystem/NewTabPage/NewTabPageViewModel.cs 0.00% <0.00%> (ø)
...ods.App.UI/WorkspaceSystem/Panel/PanelViewModel.cs 68.82% <0.00%> (ø)
...UI/WorkspaceSystem/Controllers/OpenPageBehavior.cs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@Al12rs Al12rs merged commit 10dff7d into main Feb 15, 2024
3 checks passed
@Al12rs Al12rs deleted the simpler_OpenPageBehavior branch February 15, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants