Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update App UI Layout, add Workspaces and Tab names #950

Merged
merged 10 commits into from
Feb 15, 2024
Merged

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Feb 15, 2024

closes #706

  • Update MainWindow App ToolBar layout
  • Add Workspace Title to App ToolBar
  • Remove search from ToolBar
  • Add disabled ToolBar buttons for future use
  • Fixed ToolBar Action button disabled style
  • Set Page names on their Tab Header
  • Remove Loadout Name from page toolbar since it's on the tab
- Removed Search bar (we have no plans to use it for now)
- Removed NexusLogo as per designs
- Added History, undo and redo buttons with icons
- Added Workspace Title TextBlock
- Moved premium pill to the right and fixed layout and padding
Add empty disabled commands for all the unused buttons, to disable them in the UI for now.
@Al12rs Al12rs requested a review from erri120 February 15, 2024 10:18
@Al12rs Al12rs self-assigned this Feb 15, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (d6e79c9) 58.54% compared to head (e927e19) 58.71%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #950      +/-   ##
==========================================
+ Coverage   58.54%   58.71%   +0.16%     
==========================================
  Files         626      630       +4     
  Lines       20177    20260      +83     
  Branches     1551     1557       +6     
==========================================
+ Hits        11812    11895      +83     
+ Misses       8007     8005       -2     
- Partials      358      360       +2     
Flag Coverage Δ
Linux 58.01% <70.83%> (+0.13%) ⬆️
Windows 57.96% <70.83%> (+0.15%) ⬆️
clean_environment_tests 58.69% <70.83%> (+0.16%) ⬆️
networking_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../NexusMods.App.UI/Controls/Spine/SpineViewModel.cs 68.07% <100.00%> (+0.19%) ⬆️
...NexusMods.App.UI/Pages/MyGames/MyGamesViewModel.cs 100.00% <100.00%> (ø)
src/NexusMods.App.UI/Services.cs 98.48% <100.00%> (+0.03%) ⬆️
...nts/AttachmentsFactories/HomeAttachmentsFactory.cs 100.00% <100.00%> (ø)
...tachmentsFactories/IWorkspaceAttachmentsFactory.cs 100.00% <100.00%> (ø)
...WorkspaceSystem/Controllers/WorkspaceController.cs 48.25% <100.00%> (+11.19%) ⬆️
...UI/WorkspaceSystem/Workspace/WorkspaceViewModel.cs 48.81% <100.00%> (+0.13%) ⬆️
...eAttachments/WorkspaceAttachmentsFactoryManager.cs 92.30% <88.88%> (-7.70%) ⬇️
...exusMods.App.UI/Controls/TopBar/TopBarViewModel.cs 72.83% <87.50%> (+4.50%) ⬆️
...ttachmentsFactories/DownloadsAttachmentsFactory.cs 0.00% <0.00%> (ø)
... and 4 more

... and 5 files with indirect coverage changes

Copy link
Member

@erri120 erri120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@Al12rs Al12rs requested a review from erri120 February 15, 2024 10:41
@Al12rs Al12rs merged commit 903e6fb into main Feb 15, 2024
5 checks passed
@erri120 erri120 deleted the workspace_name branch February 15, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants