Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GenericIcon to UnifiedIcon for clarity #947

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Feb 14, 2024

Simple rename.

@Al12rs Al12rs requested a review from a team February 14, 2024 11:54
@Al12rs Al12rs self-assigned this Feb 14, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8bd7919) 55.28% compared to head (6aef6a8) 55.33%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #947      +/-   ##
==========================================
+ Coverage   55.28%   55.33%   +0.05%     
==========================================
  Files         620      620              
  Lines       20058    20058              
  Branches     1545     1544       -1     
==========================================
+ Hits        11089    11100      +11     
+ Misses       8620     8614       -6     
+ Partials      349      344       -5     
Flag Coverage Δ
Linux 54.73% <0.00%> (-0.01%) ⬇️
Windows 54.59% <0.00%> (+0.03%) ⬆️
clean_environment_tests 55.31% <0.00%> (+0.04%) ⬆️
networking_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...NexusMods.App.UI/Controls/UnifiedIcon/IconValue.cs 0.00% <ø> (ø)
...WorkspaceSystem/Controllers/WorkspaceController.cs 8.02% <ø> (ø)
...em/PanelTabHeader/PanelTabHeaderDesignViewModel.cs 0.00% <ø> (ø)
...ceSystem/PanelTabHeader/PanelTabHeaderViewModel.cs 0.00% <ø> (ø)
...xusMods.App.UI/Controls/UnifiedIcon/UnifiedIcon.cs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@erri120 erri120 merged commit 96e3f76 into main Feb 14, 2024
3 checks passed
@erri120 erri120 deleted the rename_UinifiedIcon branch February 14, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants