-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back Left Menus and Left Menu Navigation #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(To be used from e.g. LeftMenu)
- Renamed downloads left menu vms to have LeftMenu in them
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
==========================================
+ Coverage 55.28% 58.57% +3.28%
==========================================
Files 620 626 +6
Lines 20058 20177 +119
Branches 1545 1551 +6
==========================================
+ Hits 11089 11818 +729
+ Misses 8620 8003 -617
- Partials 349 356 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
erri120
reviewed
Feb 14, 2024
- Remove Primary and Secondary defaults from `OpenPageBehavior` - Use new system for LeftMenu navigation
erri120
reviewed
Feb 14, 2024
src/NexusMods.App.UI/WorkspaceSystem/Workspace/WorkspaceViewModel.cs
Outdated
Show resolved
Hide resolved
erri120
reviewed
Feb 14, 2024
src/NexusMods.App.UI/WorkspaceSystem/Controllers/WorkspaceController.cs
Outdated
Show resolved
Hide resolved
erri120
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #932
WorkspaceId
toILeftMenuViewModel
and passWorkspaceContructor
etc toLeftMenuViewModel
implementations.ILeftMenuFactory
s for Loadout, Home and Downloads Left Menus.IWorkspaceAttachmentsFactoryManager
that usesILeftMenuFactories
to return attachedILeftMenuViewModels
.My Games
My Mods
andIn Progress
pages on LeftMenusOpenPageBehavior.PrimaryDefault
andOpenPageBehavior.SecondaryDefault
behaviours, for right click and middle click.WorkspaceViewModel
, necessary to make sure to bring opened page into view if it replacing an existing tab.Skipped the workspace name stuff for this PR.
I'm actually thinking of having a property on the Workspace itself, not unlike the TabName.