Fix SMAPI apply order #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al12rs
reviewed
Feb 13, 2024
| [SuppressMessage("ReSharper", "InconsistentNaming")] | ||
| public class SMAPISorter : IGeneratedSortRule, ISortRule<Mod, ModId> | ||
| { | ||
| public ITriggerFilter<ModId, Loadout> TriggerFilter => throw new NotImplementedException(); |
There was a problem hiding this comment.
Isn't this going to be a problem? If someone actually calls the TriggerFilter in the future?
There was a problem hiding this comment.
Nothing is calling this atm and I'm not sure how to properly implement this since there is no usage.
There was a problem hiding this comment.
I think the idea is that you provide a FingerPrint, if it is different from the previous one, you need to recompute the rule. I think you can return an empty fingerprint and it should never recompute it?
There was a problem hiding this comment.
That trigger isn't being used currently as the cost of re-generating the rules is low enough, not sure if we'll ever use it in the future.
Al12rs
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #930.