Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #931

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Update dependencies #931

merged 1 commit into from
Feb 12, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Feb 12, 2024

Updated most dependencies,

  • skipped Verify.Xunit as some deprecation required code changes for an outdated tag.
  • Skipped Microsoft.NET.Test.Sdk since the update was from 17.9.0-release-23619-01 to 17.9.0
  • Fixed a warning for JsonStringEnumConverter failing to serialize, used Generic version instead.

I ran the tests, ran the App tried installing some mods etc. to check for issues, didn't find anything so far.

@Al12rs Al12rs requested a review from a team February 12, 2024 10:41
@Al12rs Al12rs self-assigned this Feb 12, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (113c9c7) 55.81% compared to head (289513f) 55.78%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
- Coverage   55.81%   55.78%   -0.03%     
==========================================
  Files         616      616              
  Lines       19724    19724              
  Branches     1518     1518              
==========================================
- Hits        11008    11004       -4     
- Misses       8374     8378       +4     
  Partials      342      342              
Flag Coverage Δ
Linux 55.22% <ø> (-0.04%) ⬇️
Windows 55.08% <ø> (+0.02%) ⬆️
clean_environment_tests 55.77% <ø> (-0.03%) ⬇️
network_tests ?
networking_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@halgari halgari merged commit 8be7299 into main Feb 12, 2024
3 checks passed
@halgari halgari deleted the deps_update branch February 12, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants