Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spine UI fixes (workspaces improvements) #926

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Spine UI fixes (workspaces improvements) #926

merged 3 commits into from
Feb 12, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Feb 8, 2024

  • Highlight active workspace button on the spine
  • Add tooltips for spine buttons
@Al12rs Al12rs requested a review from erri120 February 8, 2024 17:03
@Al12rs Al12rs self-assigned this Feb 8, 2024
erri120
erri120 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@erri120 erri120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now. Similar to the current left menu solution, this doesn't scale.

I believe a better approach would be to delegate both the left menu and the active state to another component.

For the left menu, we could have a simple factory that creates the appropriate left menu via DI.

The active state could be on the spine item itself.
@Al12rs Al12rs merged commit 8b567de into main Feb 12, 2024
3 checks passed
@Al12rs Al12rs deleted the spine_fixes branch February 12, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Al12rs @erri120