Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace integration improvements #912

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Workspace integration improvements #912

merged 7 commits into from
Feb 7, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Feb 7, 2024

  • Fixed various erratic behaviour of tab header area when resizing
  • Disabled Add Panel button when it is empty
  • Closed Add Panel Drop Down when item selection is changed
  • Fixed missing bottom border of Scroll left button in tab are
  • Basic MainWindow layout and border adjustments to match new designs

This PR:
image

Latest design:
image

Stuff still needs moving around

- Avoid chain reaction of resizing by using grid to strech element, instead of manually setting Width.
- Use ScrollChanged event as source for subscriptions as it is more stable and filtered.
Close DropDown when one of the items is pressed
@Al12rs Al12rs requested a review from erri120 February 7, 2024 12:22
@Al12rs Al12rs self-assigned this Feb 7, 2024
Copy link
Member

@erri120 erri120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, resizing feels much better now.

@Al12rs
Copy link
Contributor Author

Al12rs commented Feb 7, 2024

CI tests fail with failed to open database file again

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0ebd00) 0.00% compared to head (d0d4250) 55.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #912       +/-   ##
=========================================
+ Coverage      0   55.85%   +55.85%     
=========================================
  Files         0      617      +617     
  Lines         0    19694    +19694     
  Branches      0     1512     +1512     
=========================================
+ Hits          0    11001    +11001     
- Misses        0     8354     +8354     
- Partials      0      339      +339     
Flag Coverage Δ
Linux 55.27% <100.00%> (?)
Windows 55.05% <100.00%> (?)
clean_environment_tests 55.84% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s.App.UI/Pages/LoadoutGrid/LoadoutGridViewModel.cs 63.41% <100.00%> (ø)

... and 616 files with indirect coverage changes

@Al12rs Al12rs merged commit afc3b3a into main Feb 7, 2024
4 checks passed
@Al12rs Al12rs deleted the panel_fixes branch February 7, 2024 14:48
@Al12rs Al12rs mentioned this pull request Feb 7, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants