-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace integration improvements #912
Conversation
- Avoid chain reaction of resizing by using grid to strech element, instead of manually setting Width. - Use ScrollChanged event as source for subscriptions as it is more stable and filtered.
Close DropDown when one of the items is pressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, resizing feels much better now.
CI tests fail with failed to open database file again |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #912 +/- ##
=========================================
+ Coverage 0 55.85% +55.85%
=========================================
Files 0 617 +617
Lines 0 19694 +19694
Branches 0 1512 +1512
=========================================
+ Hits 0 11001 +11001
- Misses 0 8354 +8354
- Partials 0 339 +339
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR:
![image](https://cdn.statically.io/img/private-user-images.githubusercontent.com/26797547/302988517-af121806-5557-4ece-9808-bde065944f1e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE4NDUxNTMsIm5iZiI6MTcyMTg0NDg1MywicGF0aCI6Ii8yNjc5NzU0Ny8zMDI5ODg1MTctYWYxMjE4MDYtNTU1Ny00ZWNlLTk4MDgtYmRlMDY1OTQ0ZjFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI0VDE4MTQxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFkMWM0NzcyNTk4NjFmMWI0MzVmNmNkMjY1YTI1ODY1OGM5YWZjYzUxZGJmODgxMGE3NWJlZDI4N2M2MGUyZjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.cK8Zj9lftk0LxNJr2L3fkkSG8PGPv9tI4G8Uuiim11Y)
Latest design:
![image](https://cdn.statically.io/img/private-user-images.githubusercontent.com/26797547/302988620-fae91807-81dd-4e86-ba7e-84791470e492.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE4NDUxNTMsIm5iZiI6MTcyMTg0NDg1MywicGF0aCI6Ii8yNjc5NzU0Ny8zMDI5ODg2MjAtZmFlOTE4MDctODFkZC00ZTg2LWJhN2UtODQ3OTE0NzBlNDkyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI0VDE4MTQxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNlZTIwOGJhNTQzNDlkZDA2ZDQ3NGI3MTRjZWQ0YTQ3ODE3NmMwYWQwOWI1NTk2ZmIxZjBkMTNkNWE0YWIxYzYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bdlpTuXDmmaMtATWMObLQtUCP56-psHCcvVSeP2dg9o)
Stuff still needs moving around