Workspace integration

[erri120]

Part of #706.

• add "add panel" button to toolbar
• rebase and fix conflicts
• resolve TODOs in code
  • cleanup
  • better API

[erri120]

System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
   at System.Collections.Generic.List`1.get_Item(Int32 index)
   at Avalonia.Collections.AvaloniaList`1.get_Item(Int32 index)
   at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Layout.Layoutable.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Layout.Layoutable.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Layout.Layoutable.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Layout.Layoutable.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Layout.Layoutable.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Layout.Layoutable.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Layout.Layoutable.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Layout.Layoutable.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Layout.Layoutable.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
   at Avalonia.Controls.TopLevel.HandleClosed()
   at Avalonia.Controls.WindowBase.HandleClosed()
   at Avalonia.Controls.Window.HandleClosed()
   at Avalonia.X11.X11Window.Cleanup(Boolean fromDestroyNotification)
   at Avalonia.X11.X11Window.Dispose()
   at Avalonia.Controls.Window.CloseInternal()
   at Avalonia.Controls.Window.HandleClosing(WindowCloseReason reason)
   at Avalonia.X11.X11Window.OnEvent(XEvent& ev)
   at Avalonia.X11.X11PlatformThreading.HandleX11(CancellationToken cancellationToken)
   at Avalonia.X11.X11PlatformThreading.RunLoop(CancellationToken cancellationToken)
   at Avalonia.Threading.DispatcherFrame.Run(IControlledDispatcherImpl impl)
   at Avalonia.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at Avalonia.Threading.Dispatcher.MainLoop(CancellationToken cancellationToken)
   at Avalonia.Controls.ApplicationLifetimes.ClassicDesktopStyleApplicationLifetime.Start(String[] args)
   at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime(AppBuilder builder, String[] args, ShutdownMode shutdownMode)
   at NexusMods.App.Startup.Main(IServiceProvider provider, String[] args) in /ssd-pool/projects/NexusMods/app/main/src/NexusMods.App/Startup.cs:line 19
   at NexusMods.App.StartupHandler.StartUiWindowAsync() in /ssd-pool/projects/NexusMods/app/main/src/NexusMods.App/StartupHandler.cs:line 52
   at NexusMods.SingleProcess.StartupDirector.Start(String[] args, Boolean debugMode, IAnsiConsole console)

[erri120]

Opened AvaloniaUI/Avalonia#14437

[github-actions]

This PR conflicts with main. You need to rebase the PR before it can be merged.

[github-actions]

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

[Al12rs]

See comments above

[codecov-commenter]

Codecov Report

Attention: 202 lines in your changes are missing coverage. Please review.

Comparison is base (e8436cf) 0.00% compared to head (a377501) 56.93%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##           main     #898       +/-   ##
=========================================
+ Coverage      0   56.93%   +56.93%     
=========================================
  Files         0      614      +614     
  Lines         0    19631    +19631     
  Branches      0     1503     +1503     
=========================================
+ Hits          0    11177    +11177     
- Misses        0     8118     +8118     
- Partials      0      336      +336     

Flag	Coverage Δ
Linux	56.24% <37.46%> (?)
Windows	56.21% <37.46%> (?)
clean_environment_tests	56.91% <37.46%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...e/Buttons/Download/SpineDownloadButtonViewModel.cs	100.00% <ø> (ø)
...exusMods.App.UI/Controls/TopBar/TopBarViewModel.cs	68.33% <100.00%> (ø)
.../NexusMods.App.UI/Extensions/OptionalExtensions.cs	18.18% <ø> (ø)
src/NexusMods.App.UI/Initializers.cs	66.66% <ø> (ø)
...pp.UI/LeftMenu/Game/GameLeftMenuDesignViewModel.cs	0.00% <ø> (ø)
...pp.UI/LeftMenu/Home/HomeLeftMenuDesignViewModel.cs	100.00% <100.00%> (ø)
...ent/Downloads/ViewModels/IDownloadTaskViewModel.cs	0.00% <ø> (ø)
...xusMods.App.UI/RightContent/FoundGamesViewModel.cs	77.41% <100.00%> (ø)
...tContent/LoadoutGrid/LoadoutGridDesignViewModel.cs	92.59% <100.00%> (ø)
...I/RightContent/LoadoutGrid/LoadoutGridViewModel.cs	63.11% <100.00%> (ø)
... and 28 more

... and 576 files with indirect coverage changes

[Al12rs]

I still think we might need an overview doc to outline the general structure, but otherwise the PR is Ok.

I'm going through the other one as well