Break apart Abstractions.Games #895
Conversation
…the ashes of compilation! But mark the words, the quest for debugging shall be long and treacherous, like a journey through the darkest forest.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #895 +/- ##
=========================================
+ Coverage 0 57.16% +57.16%
=========================================
Files 0 619 +619
Lines 0 19754 +19754
Branches 0 1485 +1485
=========================================
+ Hits 0 11292 +11292
- Misses 0 8125 +8125
- Partials 0 337 +337
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I found that It doesn't look like the dependencies are big, so it might be fast to remove them and rely solely on abstractions instead. |
| @@ -1,4 +1,5 @@ | |||
| using JetBrains.Annotations; | |||
| using NexusMods.Abstractions.GameLocators; | |||
| using NexusMods.Abstractions.Games.DTO; | |||
|
|
|||
| namespace NexusMods.Abstractions.Games; | |||
There was a problem hiding this comment.
There are many cases where the namespaces are no longer up to date.
Most renamed files without changes have the problem as well as a lot of other files.
Do we want to try to go through everything and fix it? Might be good to rip the band aid now since the we are already changing everything.
|
I tested this out locally and went through a lot of the files, apart from the comments above it looks good |
Handles #890
With this change, the abstractions diagram becomes this:
classDiagram direction TB DiskState --|> GameLocators DiskState --|> Loadouts FileStore --|> GameLocators FileStore --|> IO FileStore --|> Serialization Games --|> CrossPlatform Games --|> Activities Games --|> DiskState Games --|> Installers Games --|> Loadouts_Synchronizers Games --|> Loadouts Games --|> NexusWebApi Games_Diagnostics --|> FileExtractor Games_Diagnostics --|> Games GuidedInstallers --|> Activities HttpDownloader --|> Activities Installers --|> Activities Installers --|> GameLocators Installers --|> IO Installers --|> Loadouts Loadouts --|> Activities Loadouts --|> FileStore Loadouts --|> GameLocators Loadouts --|> Serialization Loadouts --|> Triggers Loadouts_Synchronizers --|> DiskState Loadouts_Synchronizers --|> Loadouts NexusWebApi --|> FileStore NexusWebApi --|> GameLocators NexusWebApi --|> SerializationIt's a bit messy, but the main win here is breaking "Game Locators" apart from "Game", this allows us to explode the contents of the old
Gameslibrary out into the different parts:ILocatableGameinstead ofIGameIGamehelpers.IGameinherits fromILocatableGame