-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for OSX in the App #877
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
==========================================
+ Coverage 55.33% 58.61% +3.27%
==========================================
Files 620 632 +12
Lines 20058 20326 +268
Branches 1544 1564 +20
==========================================
+ Hits 11100 11914 +814
+ Misses 8614 8050 -564
- Partials 344 362 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
src/Abstractions/NexusMods.Abstractions.FileExtractor/IFileExtractorSettings.cs
Outdated
Show resolved
Hide resolved
This PR conflicts with |
This PR doesn't conflict with |
… run from the main app thread
This should be good to merge. I had to implement some code to make sure the UI always runs on the main thread (the thread that calls With that we're good to go for OSX support. I need to get in NXM link support, and figure out release/updating but I'll file other issues for that |
src/Abstractions/NexusMods.Abstractions.FileExtractor/IFileExtractorSettings.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
The app will run in debug mode, with the debugger running. What works:
[ ]Downloading files (need NXM handler) Supportnxm://
links on OSX #962[ ]Updating the app (needs a release first) Support MacOS updating #964(Single process code seems broken on OSX)(fixed)