Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for OSX in the App #877

Merged
merged 11 commits into from
Feb 17, 2024
Merged

Conversation

halgari
Copy link
Collaborator

@halgari halgari commented Jan 28, 2024

The app will run in debug mode, with the debugger running. What works:

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (96e3f76) 55.33% compared to head (3651332) 58.61%.
Report is 14 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
+ Coverage   55.33%   58.61%   +3.27%     
==========================================
  Files         620      632      +12     
  Lines       20058    20326     +268     
  Branches     1544     1564      +20     
==========================================
+ Hits        11100    11914     +814     
+ Misses       8614     8050     -564     
- Partials      344      362      +18     
Flag Coverage Δ
Linux 57.85% <14.81%> (+3.12%) ⬆️
Windows 57.79% <11.11%> (+3.20%) ⬆️
clean_environment_tests 58.59% <23.45%> (+3.28%) ⬆️
macOS 57.25% <19.75%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...stractions.FileExtractor/IFileExtractorSettings.cs 66.66% <100.00%> (ø)
...Mods.FileExtractor/Extractors/SevenZipExtractor.cs 74.33% <ø> (-0.45%) ⬇️
src/NexusMods.App/AppConfig.cs 72.58% <100.00%> (ø)
src/NexusMods.CrossPlatform/Services.cs 100.00% <100.00%> (+5.26%) ⬆️
src/NexusMods.DataModel/IDataModelSettings.cs 60.86% <100.00%> (ø)
src/NexusMods.DataModel/SqliteDataStore.cs 77.89% <100.00%> (+0.23%) ⬆️
src/NexusMods.StandardGameLocators/Services.cs 79.54% <100.00%> (+2.04%) ⬆️
src/NexusMods.App/Services.cs 83.95% <0.00%> (ø)
src/NexusMods.App/Startup.cs 48.00% <0.00%> (-4.18%) ⬇️
...rm/ProtocolRegistration/ProtocolRegistrationOSX.cs 0.00% <0.00%> (ø)
... and 3 more

... and 73 files with indirect coverage changes

Copy link
Member

@erri120 erri120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@halgari
Copy link
Collaborator Author

halgari commented Feb 16, 2024

This should be good to merge. I had to implement some code to make sure the UI always runs on the main thread (the thread that calls Main. Turns out that the fact that this has worked this long is a side effect of our OS implementations not a design feature of Avalonia. AvaloniaUI/Avalonia#12554 Avalonia has no plans to lift this restriction.

With that we're good to go for OSX support. I need to get in NXM link support, and figure out release/updating but I'll file other issues for that

Copy link
Member

@erri120 erri120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@halgari halgari requested a review from erri120 February 17, 2024 14:39
@halgari halgari merged commit 0de5e45 into main Feb 17, 2024
6 checks passed
@halgari halgari deleted the osx-support-for-real-really-this-time branch February 17, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants