Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Workspace and Tab controller #872

Merged
merged 11 commits into from
Jan 29, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Jan 25, 2024

Related to #706.

  • Consolidates navigation into the IWorkspaceController.
  • Allows pages to change the title and icon of their tab using the ITabController.
@erri120 erri120 added the Design UI/UX This is related to the UI. label Jan 25, 2024
@erri120 erri120 added this to the v0.3 milestone Jan 25, 2024
@erri120 erri120 requested a review from Al12rs January 25, 2024 13:39
@erri120 erri120 self-assigned this Jan 25, 2024
@erri120
Copy link
Member Author

erri120 commented Jan 25, 2024

2024-01-25T13:41:43.1100592Z [xUnit.net 00:00:01.09]   Finished:    NexusMods.Games.RedEngine.Tests
2024-01-25T13:41:43.1106609Z [xUnit.net 00:00:01.11]     [FATAL ERROR] System.ObjectDisposedException
2024-01-25T13:41:43.1110352Z [xUnit.net 00:00:01.11]       System.ObjectDisposedException : Cannot access a disposed object.
2024-01-25T13:41:43.1112061Z [xUnit.net 00:00:01.11]       Object name: 'Microsoft.Win32.SafeHandles.SafeWaitHandle'.
2024-01-25T13:41:43.1113025Z [xUnit.net 00:00:01.11]       Stack Trace:
2024-01-25T13:41:43.1114231Z [xUnit.net 00:00:01.11]            at System.Runtime.InteropServices.SafeHandle.DangerousAddRef(Boolean& success)
2024-01-25T13:41:43.1115697Z [xUnit.net 00:00:01.11]            at Interop.Kernel32.SetEvent(SafeWaitHandle handle)
2024-01-25T13:41:43.1116839Z [xUnit.net 00:00:01.11]            at System.Threading.EventWaitHandle.Set()
2024-01-25T13:41:43.1119795Z [xUnit.net 00:00:01.11]         /_/src/xunit.runner.utility/Extensions/MessageSinkMessageExtensions.cs(39,0): at MessageSinkMessageExtensions.Dispatch[TMessage](IMessageSinkMessage message, HashSet`1 messageTypes, MessageHandler`1 callback)
2024-01-25T13:41:44.1287611Z   Passed NexusMods.Games.FOMOD.Tests.IniParsingTests.ParseIniTest [25 ms]

This issue is once again preventing the tests from succeeding.

Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@erri120 erri120 requested a review from Al12rs January 29, 2024 12:51
@Al12rs Al12rs merged commit 57852bc into Nexus-Mods:main Jan 29, 2024
5 checks passed
@erri120 erri120 deleted the issue-706/workspace-controllers branch January 29, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design UI/UX This is related to the UI.
3 participants