Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Abstraction Work #869

Merged
merged 28 commits into from
Jan 25, 2024
Merged

Additional Abstraction Work #869

merged 28 commits into from
Jan 25, 2024

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Jan 24, 2024

Fell asleep before I could PR this yesterday 😅, so here we are.

In the meantime, while this is being reviewed, I'll:

  • Write doc file of current project layout
  • Solve merge conflicts with main.

Due to the nature of this PR, some bikeshedding is expected, this is ok.
@Sewer56
Integrate New Tree System
91c3a3f
@Sewer56
Added: Fixes for failing tests
ae6149e
@Sewer56
Fixed: Broken assertions, and code tied to tests which originally sho…
31305b0 
…uld not have passed
@Sewer56
Changed: Use NexusMods.Paths from NuGet
a88acdd
@Sewer56
Merge remote-tracking branch 'origin/main' into new-trees
0ca5272
@Sewer56
Small correction to struct size info.
5df4008
@Sewer56
Bannerlord: If a module has no parent, assume depth of 0.
ec24008
@Sewer56
Moved LocationId to Abstractions Package, Cleaned up Unused Usings
4e26056
@Sewer56
[Backup] Incomplete Abstraction Code. Saving for Monday
e55c60d
@Sewer56
WIP: 22/01/2024
eb67c38
@Sewer56
WIP: 23/01/2024
cc5f681
@Sewer56
Fixed: Bad extension port of Diff
f8a2240
@Sewer56
Changed: Split up former 'common' tests.
a9e13ab
@Sewer56
Remaining Test Refactoring
069a05a
@Sewer56
Added: Missing IIdGenerator
5b99d1a
@Sewer56
Our .sln file contains invalid project, let's fix this.
1b89abe
@Sewer56
Added: Migrated Remaining Use of Trees
18dcfa0
@Sewer56 Sewer56 added meta-improvement An issue that improves an existing feature meta-chore A task that enables/benefits the team and development labels Jan 24, 2024
@Sewer56 Sewer56 requested a review from halgari January 24, 2024 14:47
@Sewer56 Sewer56 self-assigned this Jan 24, 2024
@erri120 erri120 changed the title Additional Abstraction Work (Closes #207) Jan 24, 2024
halgari
halgari approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@halgari halgari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is massive, and edits 700 files, but it's 99% namespace renaming. Looks good
@halgari halgari merged commit 5a5e253 into main Jan 25, 2024
5 checks passed
@halgari halgari deleted the more-abstractions branch January 25, 2024 14:48
@Sewer56 Sewer56 mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-chore A task that enables/benefits the team and development meta-improvement An issue that improves an existing feature
3 participants
@Sewer56 @halgari @Al12rs