Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOMOD installer fixes #867

Merged
merged 13 commits into from
Jan 29, 2024
Merged

FOMOD installer fixes #867

merged 13 commits into from
Jan 29, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Jan 24, 2024

Changes:

EDIT: further changes after reviewing with Design:

  • Switched highlighted option description and image, so that description would always be visible.
  • Various padding/spacing fixes.
  • Fix Caps on Finish button.
  • Fix auto scrolling to last option when new step is loaded.
@Al12rs Al12rs requested a review from erri120 January 24, 2024 14:00
@Al12rs Al12rs self-assigned this Jan 24, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (23a4b1d) 60.37% compared to head (241d788) 60.33%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
- Coverage   60.37%   60.33%   -0.05%     
==========================================
  Files         592      592              
  Lines       18375    18397      +22     
  Branches     1424     1427       +3     
==========================================
+ Hits        11094    11099       +5     
- Misses       6945     6963      +18     
+ Partials      336      335       -1     
Flag Coverage Δ
Linux 59.69% <13.33%> (-0.03%) ⬇️
Windows 59.56% <13.33%> (-0.03%) ⬇️
clean_environment_tests 60.31% <13.33%> (-0.05%) ⬇️
networking_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Mods.FileExtractor/Extractors/SevenZipExtractor.cs 73.68% <100.00%> (ø)
src/Games/NexusMods.Games.FOMOD/FomodAnalyzer.cs 95.38% <66.66%> (+3.32%) ⬆️
...s.Common/GuidedInstaller/GuidedInstallationStep.cs 42.85% <0.00%> (-7.15%) ⬇️
...es.FOMOD.UI/Group/GuidedInstallerGroupViewModel.cs 0.00% <0.00%> (ø)
.../NexusMods.Games.FOMOD/CoreDelegates/UiDelegate.cs 5.55% <7.69%> (-0.19%) ⬇️

... and 6 files with indirect coverage changes

Copy link
Member

@erri120 erri120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments for changes.

Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@erri120 erri120 merged commit a8b3cd6 into main Jan 29, 2024
4 checks passed
@erri120 erri120 deleted the Fomod_fixes branch January 29, 2024 10:27
@erri120 erri120 added this to the v0.3 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants