-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOMOD installer fixes #867
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #867 +/- ##
==========================================
- Coverage 60.37% 60.33% -0.05%
==========================================
Files 592 592
Lines 18375 18397 +22
Branches 1424 1427 +3
==========================================
+ Hits 11094 11099 +5
- Misses 6945 6963 +18
+ Partials 336 335 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments for changes.
This PR conflicts with |
This PR doesn't conflict with |
Depending on the order of subscription executing the image could be hidden even when present.
Consider Finish page as part of number of steps.
…tion. Remove the double border.
Do so by ignoring initial value in subscriptions that update the Highlighted option.
Changes:
EDIT: further changes after reviewing with Design: