Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Download fixes #857

Merged
merged 53 commits into from
Jan 23, 2024
Merged

Various Download fixes #857

merged 53 commits into from
Jan 23, 2024

Conversation

Fixes download getting double the progress value
- Don't replace existing Activity when resuming.
- Update starting progress when resuming activity.
- Added StartOrResume that updates the starting time and starting value of an activity.
- Exclude Starting progress when computing throughput
- Fix estimated remaining time computation.
- Throughput will still be incorrect while activity is suspended as telling the activity it was suspended resulted difficult.
- Changed total time to Remaining time, since Start time is now getting updated.
Make IsRunning consider only actively downloading dls
Avoid listening for Task value changes.
- Fix Suspend All and Resume all button states and functionality
- Update cancel dialog to support multiselection
- Change the color of the counter when there are no active dls.
- Removed InProgressCommonVM, DesignVM inherits from InProgressVM directly
- Added parameterless constructor for design/tests version.
- Have a protected DesignTimeDownloadTasks SourceList that can be updated from the DesignVM
- Bind Tasks to DesignTimeDownloadTasks in the design time parameterless constructor.
- This is to avoid Tasks changing value in the DesignVM, which would break all bindings to it or require messy nested subscriptions.
Copy link
Member

@erri120 erri120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left comments on things to change.

@Al12rs
Copy link
Contributor Author

Al12rs commented Jan 23, 2024

I've left comments on things to change.

I'm going through fixing them. Thanks for going into details, I really appreciate all the chances for improvements.

@codecov-commenter
Copy link

Codecov Report

Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (61089f3) 0.00% compared to head (9cb0ad8) 60.37%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #857       +/-   ##
=========================================
+ Coverage      0   60.37%   +60.37%     
=========================================
  Files         0      592      +592     
  Lines         0    18359    +18359     
  Branches      0     1424     +1424     
=========================================
+ Hits          0    11084    +11084     
- Misses        0     6939     +6939     
- Partials      0      336      +336     
Flag Coverage Δ
Linux 59.68% <69.49%> (?)
Windows 59.60% <71.46%> (?)
clean_environment_tests 60.36% <71.46%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ds.Networking.HttpDownloader/DTOs/DownloadState.cs 100.00% <100.00%> (ø)
...e/Buttons/Download/SpineDownloadButtonViewModel.cs 100.00% <100.00%> (ø)
src/NexusMods.App.UI/Helpers/StringFormatters.cs 87.50% <100.00%> (ø)
...rc/NexusMods.App.UI/Overlays/IOverlayController.cs 44.44% <ø> (ø)
...ightContent/Downloads/InProgressDesignViewModel.cs 100.00% <100.00%> (ø)
...exusFluentDark/Styles/Controls/Border/Toolbar.xaml 97.50% <100.00%> (ø)
...exusMods.Networking.Downloaders/DownloadService.cs 86.36% <94.44%> (ø)
src/NexusMods.App.UI/Overlays/OverlayController.cs 84.78% <0.00%> (ø)
.../NexusMods.DataModel/Activities/ActivityMonitor.cs 93.10% <0.00%> (ø)
...etworking.HttpDownloader/AdvancedHttpDownloader.cs 78.65% <90.90%> (ø)
... and 7 more

... and 575 files with indirect coverage changes

@Al12rs Al12rs merged commit 34604e7 into main Jan 23, 2024
5 checks passed
@erri120 erri120 deleted the fix-download branch January 23, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants