-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Download fixes #857
Conversation
Fixes download getting double the progress value
- Don't replace existing Activity when resuming. - Update starting progress when resuming activity. - Added StartOrResume that updates the starting time and starting value of an activity. - Exclude Starting progress when computing throughput - Fix estimated remaining time computation. - Throughput will still be incorrect while activity is suspended as telling the activity it was suspended resulted difficult. - Changed total time to Remaining time, since Start time is now getting updated.
Make IsRunning consider only actively downloading dls
Avoid listening for Task value changes. - Fix Suspend All and Resume all button states and functionality
- Update cancel dialog to support multiselection
- Change the color of the counter when there are no active dls.
- Removed InProgressCommonVM, DesignVM inherits from InProgressVM directly - Added parameterless constructor for design/tests version. - Have a protected DesignTimeDownloadTasks SourceList that can be updated from the DesignVM - Bind Tasks to DesignTimeDownloadTasks in the design time parameterless constructor. - This is to avoid Tasks changing value in the DesignVM, which would break all bindings to it or require messy nested subscriptions.
src/NexusMods.App.UI/Controls/Spine/Buttons/Download/SpineDownloadButtonViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Controls/Spine/Buttons/Download/SpineDownloadButtonViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Overlays/Download/Cancel/CancelDownloadOverlayView.axaml.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Overlays/Download/Cancel/CancelDownloadOverlayViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/RightContent/Downloads/InProgressViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/RightContent/Downloads/InProgressViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/RightContent/Downloads/InProgressViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/RightContent/Downloads/InProgressViewModel.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left comments on things to change.
I'm going through fixing them. Thanks for going into details, I really appreciate all the chances for improvements. |
…r updated after subscriptions are made.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
=========================================
+ Coverage 0 60.37% +60.37%
=========================================
Files 0 592 +592
Lines 0 18359 +18359
Branches 0 1424 +1424
=========================================
+ Hits 0 11084 +11084
- Misses 0 6939 +6939
- Partials 0 336 +336
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR addresses some of the issues identified from QA testing the download process:
In more details: