Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace styling #855

Merged
merged 20 commits into from
Jan 23, 2024
Merged

Workspace styling #855

merged 20 commits into from
Jan 23, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Jan 22, 2024

Resolves #674.

  • Tab header and tabs now have correct borders
  • Fixes alignments and paddings
@erri120 erri120 added this to the v0.3 milestone Jan 22, 2024
@erri120 erri120 requested a review from Al12rs January 22, 2024 14:09
@erri120 erri120 self-assigned this Jan 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (bd795f5) 0.00% compared to head (571fe1f) 60.35%.
Report is 6 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #855       +/-   ##
=========================================
+ Coverage      0   60.35%   +60.35%     
=========================================
  Files         0      592      +592     
  Lines         0    18375    +18375     
  Branches      0     1424     +1424     
=========================================
+ Hits          0    11090    +11090     
- Misses        0     6949     +6949     
- Partials      0      336      +336     
Flag Coverage Δ
Linux 59.70% <0.00%> (?)
Windows 59.59% <0.00%> (?)
clean_environment_tests 60.33% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ceSystem/PanelTabHeader/PanelTabHeaderViewModel.cs 0.00% <0.00%> (ø)
...ods.App.UI/WorkspaceSystem/Panel/PanelViewModel.cs 0.00% <0.00%> (ø)

... and 590 files with indirect coverage changes

@erri120 erri120 requested a review from Al12rs January 23, 2024 10:39
@erri120
Copy link
Member Author

erri120 commented Jan 23, 2024

Tests keep failing:

2024-01-23T09:38:04.2742273Z Microsoft (R) Test Execution Command Line Tool Version 17.8.0 (x64)
2024-01-23T09:38:04.2744021Z Copyright (c) Microsoft Corporation.  All rights reserved.
2024-01-23T09:38:04.2797127Z 
2024-01-23T09:38:04.3603800Z Starting test execution, please wait...
2024-01-23T09:38:04.3995003Z A total of 1 test files matched the specified pattern.
2024-01-23T09:38:05.8955494Z   Passed NexusMods.DataModel.Tests.ToolTests.CanRunTools [1 s]
2024-01-23T09:38:05.8956920Z   Passed NexusMods.DataModel.Tests.SortTests.FirstItemsComeFirst [43 ms]
2024-01-23T09:38:08.9739016Z [xUnit.net 00:00:00.03] xUnit.net VSTest Adapter v2.5.5+28b46ff510 (64-bit .NET 8.0.1)
2024-01-23T09:38:09.2129401Z [xUnit.net 00:00:00.30]   Discovering: NexusMods.Games.BladeAndSorcery.Tests
2024-01-23T09:38:09.3041005Z [xUnit.net 00:00:00.39]   Discovered:  NexusMods.Games.BladeAndSorcery.Tests
2024-01-23T09:38:09.3112965Z [xUnit.net 00:00:00.40]   Starting:    NexusMods.Games.BladeAndSorcery.Tests
2024-01-23T09:38:11.0075223Z [xUnit.net 00:00:02.09]   Finished:    NexusMods.Games.BladeAndSorcery.Tests
2024-01-23T09:38:11.0398113Z [xUnit.net 00:00:02.12]     [FATAL ERROR] System.ObjectDisposedException
2024-01-23T09:38:11.0409697Z [xUnit.net 00:00:02.12]       System.ObjectDisposedException : Cannot access a disposed object.
2024-01-23T09:38:11.0416331Z [xUnit.net 00:00:02.13]       Object name: 'Microsoft.Win32.SafeHandles.SafeWaitHandle'.
2024-01-23T09:38:11.0425447Z [xUnit.net 00:00:02.13]       Stack Trace:
2024-01-23T09:38:11.0434742Z [xUnit.net 00:00:02.13]            at System.Runtime.InteropServices.SafeHandle.DangerousAddRef(Boolean& success)
2024-01-23T09:38:11.0441061Z [xUnit.net 00:00:02.13]            at Interop.Kernel32.SetEvent(SafeWaitHandle handle)
2024-01-23T09:38:11.0447444Z [xUnit.net 00:00:02.13]            at System.Threading.EventWaitHandle.Set()
2024-01-23T09:38:11.0451293Z [xUnit.net 00:00:02.13]         /_/src/xunit.runner.utility/Extensions/MessageSinkMessageExtensions.cs(39,0): at MessageSinkMessageExtensions.Dispatch[TMessage](IMessageSinkMessage message, HashSet`1 messageTypes, MessageHandler`1 callback)
2024-01-23T09:38:11.7938984Z   Passed NexusMods.Games.BladeAndSorcery.Tests.Installers.BladeAndSorceryModInstallerTests.Test_GetMods [1 s]
2024-01-23T09:38:13.6109479Z 
2024-01-23T09:38:13.6326557Z Test Run Failed.
@erri120 erri120 merged commit 23a4b1d into Nexus-Mods:main Jan 23, 2024
4 checks passed
@erri120 erri120 deleted the workspace-styling branch January 23, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants