Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework resizers #839

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Rework resizers #839

merged 6 commits into from
Jan 17, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Jan 15, 2024

Resolves #791

This PR rewrites the resizer code to make it more robust and to follow the Figma design.

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP

WIP
@erri120 erri120 added this to the v0.3 milestone Jan 15, 2024
@erri120 erri120 requested a review from Al12rs January 15, 2024 13:38
@erri120 erri120 self-assigned this Jan 15, 2024
@erri120 erri120 marked this pull request as ready for review January 16, 2024 09:26
@codecov-commenter
Copy link

Codecov Report

Attention: 79 lines in your changes are missing coverage. Please review.

Comparison is base (2f65741) 60.25% compared to head (23b86d8) 60.36%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
+ Coverage   60.25%   60.36%   +0.11%     
==========================================
  Files         594      594              
  Lines       18130    18224      +94     
  Branches     1372     1412      +40     
==========================================
+ Hits        10924    11001      +77     
- Misses       6885     6890       +5     
- Partials      321      333      +12     
Flag Coverage Δ
Linux 59.72% <65.19%> (+0.13%) ⬆️
Windows 59.60% <65.19%> (+0.15%) ⬆️
clean_environment_tests 60.35% <65.19%> (+0.11%) ⬆️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...sMods.App.UI/WorkspaceSystem/WorkspaceGridState.cs 61.98% <ø> (ø)
src/NexusMods.App.UI/WorkspaceSystem/MathUtils.cs 88.67% <69.23%> (-5.67%) ⬇️
...NexusMods.App.UI/WorkspaceSystem/PanelGridState.cs 80.95% <63.63%> (-19.05%) ⬇️
...kspaceSystem/PanelResizer/PanelResizerViewModel.cs 0.00% <0.00%> (ø)
...UI/WorkspaceSystem/Workspace/WorkspaceViewModel.cs 0.00% <0.00%> (ø)
src/NexusMods.App.UI/WorkspaceSystem/GridUtils.cs 90.04% <82.50%> (-5.48%) ⬇️

... and 47 files with indirect coverage changes

@erri120 erri120 requested a review from Al12rs January 17, 2024 09:58
@erri120 erri120 merged commit bd795f5 into Nexus-Mods:main Jan 17, 2024
4 checks passed
@erri120 erri120 deleted the issue-791-resizers branch January 17, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants