Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate activity to report Chunk dl reading progress. #835

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Jan 11, 2024

Fixes download getting double the progress value
Fixes #834

Fixes download getting double the progress value
@Al12rs Al12rs requested a review from a team January 11, 2024 16:16
@Al12rs Al12rs self-assigned this Jan 11, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2f65741) 60.25% compared to head (b1588fd) 60.30%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
+ Coverage   60.25%   60.30%   +0.05%     
==========================================
  Files         594      594              
  Lines       18130    18104      -26     
  Branches     1372     1382      +10     
==========================================
- Hits        10924    10918       -6     
+ Misses       6885     6869      -16     
+ Partials      321      317       -4     
Flag Coverage Δ
Linux 59.66% <83.33%> (+0.06%) ⬆️
Windows 59.52% <83.33%> (+0.07%) ⬆️
clean_environment_tests 60.29% <83.33%> (+0.05%) ⬆️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...etworking.HttpDownloader/AdvancedHttpDownloader.cs 78.23% <100.00%> (+0.20%) ⬆️
...ds.Networking.Downloaders/Tasks/NxmDownloadTask.cs 0.00% <0.00%> (ø)

... and 41 files with indirect coverage changes

Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably good.
Just in case, CC @halgari

@Al12rs Al12rs requested a review from halgari January 15, 2024 16:48
@halgari halgari merged commit 50d11ab into main Jan 17, 2024
3 checks passed
@halgari halgari deleted the fix_download_progress branch January 17, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants