Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SyncFile path #827

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Update SyncFile path #827

merged 1 commit into from
Jan 9, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Jan 9, 2024

Small change to move the sync file into its correct directory.

@erri120 erri120 requested a review from a team January 9, 2024 09:04
@erri120 erri120 self-assigned this Jan 9, 2024
@erri120
Copy link
Member Author

erri120 commented Jan 9, 2024

https://github.com/Nexus-Mods/NexusMods.App/actions/runs/7458869242/job/20293697908?pr=827

2024-01-09T09:08:31.4103713Z The active test run was aborted. Reason: Test host process crashed : Unhandled exception. System.ObjectDisposedException: Cannot access a disposed object.
2024-01-09T09:08:31.4106050Z Object name: 'Microsoft.Win32.SafeHandles.SafeWaitHandle'.
2024-01-09T09:08:31.4107363Z    at System.Runtime.InteropServices.SafeHandle.DangerousAddRef(Boolean& success)
2024-01-09T09:08:31.4109262Z    at Interop.Kernel32.SetEvent(SafeWaitHandle handle)
2024-01-09T09:08:31.4110296Z    at System.Threading.EventWaitHandle.Set()
2024-01-09T09:08:31.4112176Z    at Xunit.Runner.VisualStudio.VsExecutionSink.HandleTestAssemblyFinished(MessageHandlerArgs`1 args) in /_/src/xunit.runner.visualstudio/Sinks/VsExecutionSink.cs:line 108
2024-01-09T09:08:31.4115378Z    at MessageSinkMessageExtensions.Dispatch[TMessage](IMessageSinkMessage message, HashSet`1 messageTypes, MessageHandler`1 callback) in /_/src/xunit.runner.utility/Extensions/MessageSinkMessageExtensions.cs:line 39
2024-01-09T09:08:31.4118641Z    at Xunit.ExecutionEventSink.OnMessageWithTypes(IMessageSinkMessage message, HashSet`1 messageTypes) in /_/src/xunit.runner.utility/Sinks/EventSinks/ExecutionEventSink.cs:line 167
2024-01-09T09:08:31.4122537Z    at Xunit.AggregateMessageSink.OnMessageWithTypes(IMessageSinkMessage message, HashSet`1 messageTypes) in /_/src/xunit.runner.utility/Sinks/AggregateMessageSink.cs:line 66
2024-01-09T09:08:31.4125551Z    at Xunit.Runner.VisualStudio.VsExecutionSink.OnMessageWithTypes(IMessageSinkMessage message, HashSet`1 messageTypes) in /_/src/xunit.runner.visualstudio/Sinks/VsExecutionSink.cs:line 319
2024-01-09T09:08:31.4128463Z    at Xunit.ExecutionSink.OnMessageWithTypes(IMessageSinkMessage message, HashSet`1 messageTypes) in /_/src/xunit.runner.utility/Sinks/ExecutionSink.cs:line 444
2024-01-09T09:08:31.4131226Z    at Xunit.MessageSinkAdapter.OnMessageWithTypes(IMessageSinkMessage message, HashSet`1 messageTypes) in /_/src/xunit.runner.utility/Messages/MessageSinkAdapter.cs:line 50
2024-01-09T09:08:31.4133922Z    at Xunit.OptimizedRemoteMessageSink.OnMessage(IMessageSinkMessage message) in /_/src/xunit.runner.utility/Messages/OptimizedRemoteMessageSink.cs:line 56
2024-01-09T09:08:31.4136404Z    at Xunit.Sdk.SynchronousMessageBus.QueueMessage(IMessageSinkMessage message) in /_/src/xunit.execution/Sdk/SynchronousMessageBus.cs:line 30
2024-01-09T09:08:31.4138590Z    at Xunit.Sdk.TestAssemblyRunner`1.RunAsync() in /_/src/xunit.execution/Sdk/Frameworks/Runners/TestAssemblyRunner.cs:line 220
2024-01-09T09:08:31.4141347Z    at Xunit.DependencyInjection.DependencyInjectionTestFrameworkExecutor.RunTestCases(IEnumerable`1 testCases, IMessageSink executionMessageSink, ITestFrameworkExecutionOptions executionOptions)
2024-01-09T09:08:31.4143582Z    at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_1(Object state)
2024-01-09T09:08:31.4144621Z    at System.Threading.ThreadPoolWorkQueue.Dispatch()
2024-01-09T09:08:31.4145734Z    at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()
@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (ee141e3) 61.53% compared to head (6876a12) 61.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   61.53%   61.54%           
=======================================
  Files         618      618           
  Lines       19083    19092    +9     
  Branches     1396     1396           
=======================================
+ Hits        11743    11750    +7     
- Misses       6994     6996    +2     
  Partials      346      346           
Flag Coverage Δ
Linux 60.87% <16.66%> (-0.04%) ⬇️
Windows 60.75% <16.66%> (-0.06%) ⬇️
clean_environment_tests 61.52% <16.66%> (+<0.01%) ⬆️
networking_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/NexusMods.App/Services.cs 82.66% <16.66%> (-8.25%) ⬇️

... and 5 files with indirect coverage changes

@erri120 erri120 merged commit d98bd7a into Nexus-Mods:main Jan 9, 2024
3 checks passed
@erri120 erri120 deleted the update-sync-path branch January 9, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants