Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panel splitting #813

Merged
merged 12 commits into from
Dec 11, 2023
Merged

Fix panel splitting #813

merged 12 commits into from
Dec 11, 2023

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Dec 11, 2023

Fixes the panel splitting algorithm to respect the joined panels, depending on the orientation.

Related to #674 and 791.

@erri120 erri120 added this to the v0.3 milestone Dec 11, 2023
@erri120 erri120 self-assigned this Dec 11, 2023
@erri120 erri120 mentioned this pull request Dec 11, 2023
8 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #813 (7327b11) into main (17bf70e) will increase coverage by 61.45%.
The diff coverage is 92.69%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #813       +/-   ##
=========================================
+ Coverage      0   61.45%   +61.45%     
=========================================
  Files         0      618      +618     
  Lines         0    19028    +19028     
  Branches      0     1388     +1388     
=========================================
+ Hits          0    11693    +11693     
- Misses        0     6989     +6989     
- Partials      0      346      +346     
Flag Coverage Δ
Linux 60.79% <92.69%> (?)
Windows 60.72% <92.69%> (?)
clean_environment_tests 61.43% <92.69%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/NexusMods.App.UI/WorkspaceSystem/GridUtils.cs 94.80% <100.00%> (ø)
...spaceSystem/WorkspaceGridState.ColumnEnumerator.cs 100.00% <100.00%> (ø)
...orkspaceSystem/WorkspaceGridState.RowEnumerator.cs 100.00% <100.00%> (ø)
...stem/WorkspaceGridState.AdjacentPanelEnumerator.cs 92.30% <92.30%> (ø)
...sMods.App.UI/WorkspaceSystem/WorkspaceGridState.cs 63.63% <78.26%> (ø)
...UI/WorkspaceSystem/Workspace/WorkspaceViewModel.cs 0.00% <0.00%> (ø)

... and 612 files with indirect coverage changes

@erri120 erri120 requested a review from a team December 11, 2023 15:38
@Al12rs Al12rs self-requested a review December 11, 2023 15:59
@erri120 erri120 merged commit 5de5e59 into Nexus-Mods:main Dec 11, 2023
3 checks passed
@erri120 erri120 deleted the workspace-cleanup-2 branch December 11, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants