Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Advanced installer incorrectly canceling when pressing Install #808

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Dec 6, 2023

No description provided.

Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Al12rs Al12rs self-assigned this Dec 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #808 (0026f8c) into main (c9dcc7a) will increase coverage by 0.64%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
+ Coverage   60.29%   60.94%   +0.64%     
==========================================
  Files         613      613              
  Lines       18641    18641              
  Branches     1339     1339              
==========================================
+ Hits        11239    11360     +121     
+ Misses       7054     6940     -114     
+ Partials      348      341       -7     
Flag Coverage Δ
Linux 60.31% <0.00%> (+0.02%) ⬆️
Windows 60.14% <0.00%> (∅)
clean_environment_tests 60.93% <0.00%> (+0.63%) ⬆️
network_tests ?
networking_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...edInstallerPages/AdvancedInstallerPageViewModel.cs 0.00% <0.00%> (ø)

... and 34 files with indirect coverage changes

@Al12rs
Copy link
Contributor Author

Al12rs commented Dec 7, 2023

For some reason the first CI pass failed. Tried reproducing locally with no success, second pass worked.
We should keep an eye out.

@Al12rs Al12rs merged commit c6c90cc into main Dec 7, 2023
3 checks passed
@Al12rs Al12rs deleted the advanced-installer-fix branch December 7, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants