-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced installer rework #790
Conversation
…o manual-installer-ui
…o manual-installer-ui
…o manual-installer-ui
…-installer-ui-backend w/ Fixes
…-installer-ui-backend
...ames.AdvancedInstaller.UI/Content/Left/ModContent/TreeEntry/IModContentTreeEntryViewModel.cs
Outdated
Show resolved
Hide resolved
...ames.AdvancedInstaller.UI/Content/Left/ModContent/TreeEntry/IModContentTreeEntryViewModel.cs
Show resolved
Hide resolved
...ames.AdvancedInstaller.UI/Content/Left/ModContent/TreeEntry/IModContentTreeEntryViewModel.cs
Outdated
Show resolved
Hide resolved
src/Games/NexusMods.Games.AdvancedInstaller.UI/Content/Left/ModContent/ModContentViewModel.cs
Outdated
Show resolved
Hide resolved
src/Games/NexusMods.Games.AdvancedInstaller.UI/Content/Left/ModContent/ModContentViewModel.cs
Show resolved
Hide resolved
...NexusMods.Games.AdvancedInstaller.UI/Content/Right/SelectLocation/SelectLocationViewModel.cs
Show resolved
Hide resolved
...AdvancedInstaller.UI/Content/Right/SelectLocation/SuggestedEntry/ISuggestedEntryViewModel.cs
Outdated
Show resolved
Hide resolved
...AdvancedInstaller.UI/Content/Right/SelectLocation/TreeEntry/ISelectableTreeEntryViewModel.cs
Outdated
Show resolved
Hide resolved
...AdvancedInstaller.UI/Content/Right/SelectLocation/TreeEntry/SelectableTreeEntryView.axaml.cs
Show resolved
Hide resolved
....AdvancedInstaller.UI/Content/Right/SelectLocation/TreeEntry/SelectableTreeEntryViewModel.cs
Outdated
Show resolved
Hide resolved
....AdvancedInstaller.UI/Content/Right/SelectLocation/TreeEntry/SelectableTreeEntryViewModel.cs
Outdated
Show resolved
Hide resolved
tests/Games/NexusMods.Games.AdvancedInstaller.UI.Tests/AdvancedInstallerUITests.cs
Outdated
Show resolved
Hide resolved
src/Games/NexusMods.Games.AdvancedInstaller.UI/Content/BodyViewModel.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do a squash merge.
…s are passes in the other way.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
==========================================
- Coverage 63.38% 62.26% -1.12%
==========================================
Files 585 594 +9
Lines 17869 18580 +711
Branches 1254 1324 +70
==========================================
+ Hits 11326 11569 +243
- Misses 6203 6658 +455
- Partials 340 353 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Closes #750 .
This PR completely reworks the Advanced Manual installer code to follow the UI Coding Guidelines, as well as solving a number of other issues:
Addressed problems:
AdvancedInstaller.cs
file to the main AdvancedInstaller project instead of in the AdvancedInstaller UI project.Added features missing in previous version:
Scroll down to the created folder entry.(SKIPPED)Additional Changes:
Optional.ValueOr(Value)
extension method, to avoidvalueSelector
action overhead.TODO: