Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel resizing #787

Merged
merged 31 commits into from
Nov 28, 2023
Merged

Panel resizing #787

merged 31 commits into from
Nov 28, 2023

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Nov 23, 2023

Resolves #705. Part of #674.

  • Panels can be resized.
  • Panels have space in between them.
  • Future TODO: Panel resizing improvements #791
  • Hovering and interacting with the resizer should change the mouse icon.
  • Bugs:
    • Cursor icon doesn't change in previewer? Maybe doesn't change at all, I have no idea.
    • Wrong control is removed from the Children list.
    • Space isn't expanded for the other control correctly.
    • Resizers are at the wrong position after a panel has been closed.
    • New panel icons aren't updated when the user stops resizing
    • No minimum size for panels.
@erri120 erri120 added this to the v0.3 milestone Nov 23, 2023
@erri120 erri120 self-assigned this Nov 23, 2023
@Al12rs Al12rs self-requested a review November 23, 2023 10:56
@erri120 erri120 marked this pull request as ready for review November 27, 2023 11:38
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #787 (00bd2c9) into main (8dab9fa) will increase coverage by 0.59%.
Report is 7 commits behind head on main.
The diff coverage is 37.41%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
+ Coverage   62.40%   62.99%   +0.59%     
==========================================
  Files         611      586      -25     
  Lines       18572    18125     -447     
  Branches     1307     1277      -30     
==========================================
- Hits        11590    11418     -172     
+ Misses       6632     6365     -267     
+ Partials      350      342       -8     
Flag Coverage Δ
Linux 62.36% <37.41%> (+0.63%) ⬆️
Windows 62.16% <37.41%> (+0.52%) ⬆️
clean_environment_tests 62.98% <37.41%> (+0.58%) ⬆️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/NexusMods.App.UI/Theme/IconStyles.xaml 98.79% <100.00%> (+0.06%) ⬆️
src/NexusMods.App.UI/WorkspaceSystem/GridUtils.cs 92.41% <96.38%> (+3.38%) ⬆️
src/NexusMods.App.UI/WorkspaceSystem/MathUtils.cs 94.33% <88.46%> (-5.67%) ⬇️
...kspaceSystem/PanelResizer/PanelResizerViewModel.cs 0.00% <0.00%> (ø)
...UI/WorkspaceSystem/Workspace/WorkspaceViewModel.cs 0.00% <0.00%> (ø)

... and 99 files with indirect coverage changes

Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing the code locally, a lot of the interactions caused pretty bugged out states of the view, I would prefer if we at least were sure about the causes of these bugs before merging this.

});
}

// TODO: make this reactive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this TODO still relevant?

src/NexusMods.App.UI/WorkspaceSystem/GridUtils.cs Outdated Show resolved Hide resolved
@Al12rs Al12rs self-requested a review November 28, 2023 14:15
@Al12rs Al12rs merged commit 75e7bf5 into Nexus-Mods:main Nov 28, 2023
6 checks passed
@erri120 erri120 deleted the issue-705-panel-resize branch November 28, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants