-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panel resizing #787
Panel resizing #787
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
==========================================
+ Coverage 62.40% 62.99% +0.59%
==========================================
Files 611 586 -25
Lines 18572 18125 -447
Branches 1307 1277 -30
==========================================
- Hits 11590 11418 -172
+ Misses 6632 6365 -267
+ Partials 350 342 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing the code locally, a lot of the interactions caused pretty bugged out states of the view, I would prefer if we at least were sure about the causes of these bugs before merging this.
src/NexusMods.App.UI/WorkspaceSystem/PanelResizer/IPanelResizerViewModel.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/WorkspaceSystem/PanelResizer/IPanelResizerViewModel.cs
Show resolved
Hide resolved
}); | ||
} | ||
|
||
// TODO: make this reactive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this TODO still relevant?
Resolves #705. Part of #674.
Children
list.