Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Vogen #782

Merged
merged 10 commits into from
Nov 20, 2023
Merged

Replace Vogen #782

merged 10 commits into from
Nov 20, 2023

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Nov 20, 2023

Resolves #751.

@erri120 erri120 requested a review from a team November 20, 2023 12:16
@erri120 erri120 self-assigned this Nov 20, 2023
Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #782 (e8fb898) into main (fd90b03) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 58.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
- Coverage   62.49%   62.49%   -0.01%     
==========================================
  Files         611      611              
  Lines       18564    18567       +3     
  Branches     1305     1307       +2     
==========================================
+ Hits        11602    11603       +1     
+ Misses       6620     6619       -1     
- Partials      342      345       +3     
Flag Coverage Δ
Linux 61.71% <58.33%> (-0.04%) ⬇️
Windows 61.65% <58.33%> (-0.05%) ⬇️
clean_environment_tests 62.47% <58.33%> (+<0.01%) ⬆️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...exusMods.Games.AdvancedInstaller/DeploymentData.cs 97.43% <100.00%> (ø)
...BethesdaGameStudios/BethesdaLoadoutSynchronizer.cs 88.37% <100.00%> (ø)
...es.DarkestDungeon/Installers/NativeModInstaller.cs 88.33% <100.00%> (ø)
...s.Games.RedEngine/ModInstallers/RedModInstaller.cs 97.29% <100.00%> (ø)
...dEngine/ModInstallers/SimpleOverlayModInstaller.cs 90.69% <100.00%> (ø)
...ames.StardewValley/Installers/SMAPIModInstaller.cs 93.75% <100.00%> (ø)
src/NexusMods.App.UI/WorkspaceSystem/GridUtils.cs 89.03% <100.00%> (ø)
src/NexusMods.App.UI/WorkspaceSystem/IconUtils.cs 100.00% <100.00%> (ø)
src/NexusMods.DataModel/ArchiveInstaller.cs 72.60% <100.00%> (+0.18%) ⬆️
src/NexusMods.DataModel/FileOriginRegistry.cs 75.67% <100.00%> (ø)
... and 19 more

... and 3 files with indirect coverage changes

@halgari halgari merged commit 8dab9fa into Nexus-Mods:main Nov 20, 2023
6 checks passed
@erri120 erri120 deleted the issue-751-replace-vogen branch November 20, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants