Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IGeneratedSortRule rules by default #780

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

Aragas
Copy link
Contributor

@Aragas Aragas commented Nov 17, 2023

Currently, only the built-in sort rules will be considered by ALoadoutSynchronizer. Since we have a special interface IGeneratedSortRule, it should be used by default, I think would be a better default behaviour from an extension developer point of view!

I've also added SortRules propagation in ArchiveInstaller

Propagate SortRules in ArchiveInstaller
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #780 (f899d3d) into main (e624bae) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
+ Coverage   62.44%   62.50%   +0.05%     
==========================================
  Files         611      611              
  Lines       18565    18570       +5     
  Branches     1305     1305              
==========================================
+ Hits        11593    11607      +14     
+ Misses       6626     6620       -6     
+ Partials      346      343       -3     
Flag Coverage Δ
Linux 61.71% <100.00%> (-0.07%) ⬇️
Windows 61.68% <100.00%> (+0.12%) ⬆️
clean_environment_tests 62.48% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/NexusMods.DataModel/ArchiveInstaller.cs 72.78% <100.00%> (+0.18%) ⬆️
...aModel/LoadoutSynchronizer/ALoadoutSynchronizer.cs 92.12% <100.00%> (+0.09%) ⬆️

... and 4 files with indirect coverage changes

@Aragas Aragas marked this pull request as draft November 17, 2023 10:36
@Aragas Aragas marked this pull request as ready for review November 17, 2023 10:38
@Al12rs Al12rs requested a review from halgari November 20, 2023 10:11
@halgari halgari merged commit 276f775 into Nexus-Mods:main Nov 20, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants