Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArchiveInstaller propagate properties #778

Merged
merged 1 commit into from
Nov 16, 2023
Merged

ArchiveInstaller propagate properties #778

merged 1 commit into from
Nov 16, 2023

Conversation

Aragas
Copy link
Contributor

@Aragas Aragas commented Nov 16, 2023 •
edited
Loading

Version was not propagated
I'm not sure whether other properties should be propagated also
@Aragas
Copy link
Contributor Author

Aragas commented Nov 16, 2023

Do I need to fix the coverage issue? And in your opinion, should other properties like SortRules be propagated?
@Al12rs
Copy link
Contributor

Al12rs commented Nov 16, 2023

No the coverage thing is fine, we might remove it in the future.
I think we will propagate sort rules if we have an installer that actually applies some.
Thanks for the PR!
@Al12rs Al12rs merged commit e624bae into Nexus-Mods:main Nov 16, 2023
3 of 4 checks passed
@Aragas
Copy link
Contributor Author

Aragas commented Nov 16, 2023

@Al12rs the Bannerlord PR has such code
https://github.com/BUTR/NexusMods.App/blob/3d5d87f77cb68f403d2ceb5e02c8830b240e3fe9/src/Games/NexusMods.Games.MountAndBlade2Bannerlord/Installers/MountAndBlade2BannerlordModInstaller.cs#L118-L121
@Aragas Aragas deleted the bugfix/version-propagation branch November 16, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Aragas @Al12rs