Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve image blurring #775

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Nov 14, 2023

Should fix #769.

@erri120 erri120 added the Design UI/UX This is related to the UI. label Nov 14, 2023
@erri120 erri120 requested a review from a team November 14, 2023 10:58
@erri120 erri120 self-assigned this Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #775 (b12bf5e) into main (f699d8e) will increase coverage by 0.14%.
Report is 2 commits behind head on main.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
+ Coverage   62.80%   62.94%   +0.14%     
==========================================
  Files         610      609       -1     
  Lines       18456    18429      -27     
  Branches     1302     1301       -1     
==========================================
+ Hits        11591    11600       +9     
+ Misses       6520     6484      -36     
  Partials      345      345              
Flag Coverage Δ
Linux 62.28% <50.00%> (+0.15%) ⬆️
Windows 62.02% <50.00%> (+0.01%) ⬆️
clean_environment_tests 62.92% <50.00%> (+0.13%) ⬆️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/NexusMods.App.UI/WorkspaceSystem/IconUtils.cs 100.00% <100.00%> (ø)
...I/Controls/GameWidget/GameWidgetDesignViewModel.cs 0.00% <0.00%> (ø)
src/NexusMods.App.UI/ReactiveUIExtensions.cs 58.82% <0.00%> (-2.41%) ⬇️
....App.UI/Controls/GameWidget/GameWidgetViewModel.cs 81.08% <66.66%> (+41.08%) ⬆️
...usMods.App.UI/Extensions/SkiaAvaloniaExtensions.cs 42.30% <42.85%> (+42.30%) ⬆️

... and 11 files with indirect coverage changes

Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, no complaints :p

@erri120 erri120 merged commit 00aab4e into Nexus-Mods:main Nov 14, 2023
5 checks passed
@erri120 erri120 deleted the issue-769-icon-glitch branch November 14, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design UI/UX This is related to the UI.
2 participants