Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New Tab"-page with a selection screen #768

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Nov 13, 2023

Part of #674.

The "New Tab"-page now shows a dynamic selection screen with pages that the user can view.

out.mp4
@erri120 erri120 added this to the v0.3 milestone Nov 13, 2023
@erri120 erri120 requested a review from a team November 13, 2023 13:54
@erri120 erri120 self-assigned this Nov 13, 2023
@erri120 erri120 mentioned this pull request Nov 13, 2023
45 tasks
@erri120 erri120 marked this pull request as ready for review November 13, 2023 13:59
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #768 (7ff6615) into main (f699d8e) will decrease coverage by 0.53%.
Report is 2 commits behind head on main.
The diff coverage is 1.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
- Coverage   62.80%   62.28%   -0.53%     
==========================================
  Files         610      612       +2     
  Lines       18456    18575     +119     
  Branches     1302     1303       +1     
==========================================
- Hits        11591    11569      -22     
- Misses       6520     6664     +144     
+ Partials      345      342       -3     
Flag Coverage Δ
Linux 61.56% <1.67%> (-0.57%) ⬇️
Windows 61.50% <1.67%> (-0.51%) ⬇️
clean_environment_tests 62.26% <1.67%> (-0.53%) ⬇️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../NexusMods.App.UI/Controls/Dummy/DummyViewModel.cs 0.00% <ø> (ø)
...tContent/LoadoutGrid/LoadoutGridDesignViewModel.cs 92.59% <ø> (ø)
...I/RightContent/LoadoutGrid/LoadoutGridViewModel.cs 64.51% <ø> (ø)
src/NexusMods.App.UI/Services.cs 98.40% <100.00%> (+0.01%) ⬆️
...Mods.App.UI/WorkspaceSystem/Page/APageViewModel.cs 100.00% <100.00%> (ø)
...usMods.App.UI/WorkspaceSystem/Page/IPageFactory.cs 0.00% <0.00%> (ø)
src/NexusMods.App.UI/WorkspaceSystem/Page/Page.cs 0.00% <0.00%> (ø)
...pp.UI/WorkspaceSystem/Page/PageDiscoveryDetails.cs 0.00% <0.00%> (ø)
...UI/WorkspaceSystem/NewTabPage/NewTabPageFactory.cs 0.00% <0.00%> (ø)
...aceSystem/NewTabPage/NewTabPageSectionViewModel.cs 0.00% <0.00%> (ø)
... and 9 more

... and 14 files with indirect coverage changes

@erri120 erri120 merged commit d7b745e into Nexus-Mods:main Nov 15, 2023
5 of 7 checks passed
@erri120 erri120 deleted the issue-674-part-6 branch November 15, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants