Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish Manual Installer UI #765

Merged
merged 6 commits into from
Nov 13, 2023
Merged

Polish Manual Installer UI #765

merged 6 commits into from
Nov 13, 2023

Conversation

Patriot99
Copy link
Contributor

No description provided.

@erri120 erri120 requested a review from Sewer56 November 10, 2023 18:21
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #765 (c5d2fc5) into main (bec16f5) will increase coverage by 0.74%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head c5d2fc5 differs from pull request most recent head fce853d. Consider uploading reports for the commit fce853d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
+ Coverage   62.04%   62.79%   +0.74%     
==========================================
  Files         610      610              
  Lines       18455    18456       +1     
  Branches     1302     1302              
==========================================
+ Hits        11450    11589     +139     
+ Misses       6654     6525     -129     
+ Partials      351      342       -9     
Flag Coverage Δ
Linux 62.11% <ø> (+0.07%) ⬆️
Windows 61.99% <ø> (∅)
clean_environment_tests 62.77% <ø> (+0.72%) ⬆️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 33 files with indirect coverage changes

@Patriot99
Copy link
Contributor Author

I had problems with the API (login), but I managed to log in. I compared the English UI and to me, it looks good. Furthermore, I just couldn't find the strings "Include" or "Included", so I can't confirm that the strings "Dołączone", "Dołącz", "Dołączony folder", "Dołącz folder", "Dołączone z folderu" and "Dołącz z folderu" are translated correctly. A screenshot or a hint would suffice.

	</data>
	<data name="TreeEntryView_IncludeTransitionButtonTextBlock_Include_folder" xml:space="preserve">
		<value>Dołącz folder</value>
	</data>
	<data name="TreeEntryView_IncludeTransitionButtonTextBlock_Include_with_folder" xml:space="preserve">
		<value>Dołącz z folderu</value>
	</data>
	<data name="TreeEntryView_IncludedRemoveButtonTextBlock_Included_folder" xml:space="preserve">
		<value>Dołączony folder</value>
	</data>
	<data name="TreeEntryView_IncludedRemoveButtonTextBlock_Included_with_folder" xml:space="preserve">
		<value>Dołączone z folderu</value>
	</data>
	<data name="TreeEntryView_IncludeTransitionButtonTextBlock_Include" xml:space="preserve">
		<value>Dołącz</value>
	</data>
	<data name="TreeEntryView_IncludedRemoveButtonTextBlock_Included" xml:space="preserve">
		<value>Dołączone</value>
	</data>
@Sewer56
Copy link
Member

Sewer56 commented Nov 11, 2023

20231111_03h46m45s_grim
20231111_03h47m07s_grim

The designs (and App) look like this.
You should see these buttons if you select a folder which has children in it.

In this case, when 'Textures' was selected, you get the image above.
And after selection is complete, you get the image below.

Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Patriot99
Copy link
Contributor Author

I tested some advanced installations and explored the advanced manual installer process more deeply to make corrections. That's all from my side.

@halgari halgari merged commit b266b4d into Nexus-Mods:main Nov 13, 2023
3 of 5 checks passed
@Patriot99 Patriot99 deleted the patch-1 branch November 13, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants