Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up the advanced installer to a button in the UI #756

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

halgari
Copy link
Collaborator

@halgari halgari commented Nov 8, 2023

A horrible hack, and some other fixes:

  • Updates the spine VM to log an error and not crash when Skia fails to load an icon
  • Switch to PNGs for the game icons the JPG files were crashing for some reason (resolves Skia crash after upgrade #717 )
  • Adds an optional parameter to ArchiveInstaller.AddMods so you can force it to use a specific installer
  • Registers the AdvancedInstaller as an IModInstaller
  • Adds a button to the LoadoutView that will find the advanced installer and use it to install a given mod.
  • The way we find the advanced installer is a very ugly hack, but until Unnecessary Project Dependencies: Introduce Abstractions or Common Package #207 is resolved we can't do this easily
@halgari halgari requested a review from a team November 8, 2023 18:07
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #756 (7e8a7e5) into main (4486ef2) will decrease coverage by 0.15%.
The diff coverage is 53.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
- Coverage   63.04%   62.90%   -0.15%     
==========================================
  Files         606      606              
  Lines       18385    18430      +45     
  Branches     1302     1305       +3     
==========================================
+ Hits        11591    11593       +2     
- Misses       6456     6496      +40     
- Partials      338      341       +3     
Flag Coverage Δ
Linux 62.24% <53.12%> (-0.15%) ⬇️
Windows 62.14% <53.12%> (-0.11%) ⬇️
clean_environment_tests 62.88% <53.12%> (-0.14%) ⬇️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/NexusMods.Games.AdvancedInstaller.UI/Services.cs 100.00% <100.00%> (ø)
...s/Games/NexusMods.Games.TestFramework/AGameTest.cs 60.00% <100.00%> (ø)
...udios/SkyrimSpecialEdition/SkyrimSpecialEdition.cs 69.23% <0.00%> (ø)
.../NexusMods.App.UI/Controls/Spine/SpineViewModel.cs 66.16% <60.00%> (-1.04%) ⬇️
...tContent/LoadoutGrid/LoadoutGridDesignViewModel.cs 92.59% <0.00%> (-3.57%) ⬇️
src/NexusMods.DataModel/ArchiveInstaller.cs 72.41% <42.85%> (-1.88%) ⬇️
...I/RightContent/LoadoutGrid/LoadoutGridViewModel.cs 64.51% <4.16%> (-14.49%) ⬇️
...rc/NexusMods.App.UI/Resources/Language.Designer.cs 67.07% <69.62%> (+0.41%) ⬆️

... and 5 files with indirect coverage changes

@halgari halgari merged commit 7a99726 into main Nov 8, 2023
5 of 6 checks passed
@halgari halgari deleted the add-adv-install-button branch November 8, 2023 19:19
@Patriot99 Patriot99 mentioned this pull request Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant