Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace cleanup #754

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Nov 8, 2023

Conforms the workspace code to the new guidelines, improving readability, simplicity, and performance.

Related to #674.

@erri120 erri120 added this to the v0.3 milestone Nov 8, 2023
@erri120 erri120 requested a review from a team November 8, 2023 13:08
@erri120 erri120 self-assigned this Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #754 (f5f0a65) into main (9182f89) will increase coverage by 0.41%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
+ Coverage   62.70%   63.12%   +0.41%     
==========================================
  Files         585      605      +20     
  Lines       17420    18344     +924     
  Branches     1219     1298      +79     
==========================================
+ Hits        10924    11580     +656     
- Misses       6177     6422     +245     
- Partials      319      342      +23     
Flag Coverage Δ
Linux 62.50% <0.00%> (+0.53%) ⬆️
Windows 62.32% <0.00%> (+0.47%) ⬆️
clean_environment_tests 63.11% <0.00%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Mods.App.UI/WorkspaceSystem/DataStore/PanelData.cs 0.00% <0.00%> (ø)
...ceSystem/AddPanelButton/AddPanelButtonViewModel.cs 0.00% <0.00%> (ø)
...em/PanelTabHeader/PanelTabHeaderDesignViewModel.cs 0.00% <0.00%> (ø)
...p.UI/WorkspaceSystem/PanelTab/PanelTabViewModel.cs 0.00% <0.00%> (ø)
...ceSystem/PanelTabHeader/PanelTabHeaderViewModel.cs 0.00% <0.00%> (ø)
src/NexusMods.App.UI/Extensions/ListAdapter.cs 0.00% <0.00%> (ø)
...em/AddPanelButton/AddPanelButtonDesignViewModel.cs 0.00% <0.00%> (ø)
src/NexusMods.Common/EnumerableExtensions.cs 64.28% <0.00%> (-12.86%) ⬇️
...UI/WorkspaceSystem/Workspace/WorkspaceViewModel.cs 0.00% <0.00%> (ø)
...ods.App.UI/WorkspaceSystem/Panel/PanelViewModel.cs 0.00% <0.00%> (ø)

... and 58 files with indirect coverage changes

@halgari halgari merged commit 0f1d321 into Nexus-Mods:main Nov 9, 2023
5 checks passed
@erri120 erri120 deleted the issue-674-panels-part-5 branch November 9, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants