Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI coding conventions and guidelines #738

Merged
merged 32 commits into from
Nov 2, 2023

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Oct 26, 2023

Resolves #737.

  • new docs for building UIs
  • Updated the FOMOD installer UI as an example on how to apply the new guidelines
  • Updated various extension methods to be more strict
@erri120 erri120 self-assigned this Oct 26, 2023
@erri120 erri120 marked this pull request as ready for review November 2, 2023 13:33
@erri120 erri120 requested a review from halgari November 2, 2023 13:33
@erri120 erri120 added this to the v0.3 milestone Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #738 (8b9b5c1) into main (af773e8) will increase coverage by 0.22%.
The diff coverage is 0.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
+ Coverage   62.43%   62.66%   +0.22%     
==========================================
  Files         586      585       -1     
  Lines       17505    17422      -83     
  Branches     1217     1219       +2     
==========================================
- Hits        10930    10917      -13     
+ Misses       6255     6184      -71     
- Partials      320      321       +1     
Flag Coverage Δ
Linux 61.94% <0.48%> (+0.23%) ⬆️
Windows 61.85% <0.48%> (+0.21%) ⬆️
clean_environment_tests 62.64% <0.48%> (+0.22%) ⬆️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...UI/Options/GuidedInstallerOptionDesignViewModel.cs 0.00% <ø> (ø)
src/NexusMods.App.UI/AViewModel.cs 100.00% <ø> (ø)
src/NexusMods.App.UI/ServiceExtensions.cs 100.00% <ø> (ø)
...ls/Helpers/ViewModelSelector/AViewModelSelector.cs 100.00% <ø> (ø)
...lpers/ViewModelSelector/ViewModelDesignSelector.cs 100.00% <ø> (ø)
...els/Helpers/ViewModelSelector/ViewModelSelector.cs 100.00% <ø> (ø)
...ceSystem/Workspace/WorkspacePlaygroundViewModel.cs 0.00% <ø> (ø)
...OD.UI/Group/GuidedInstallerGroupDesignViewModel.cs 0.00% <0.00%> (ø)
...OMOD.UI/Step/GuidedInstallerStepDesignViewModel.cs 0.00% <0.00%> (ø)
src/NexusMods.App.UI/ReactiveUIExtensions.cs 65.21% <25.00%> (-4.56%) ⬇️
... and 4 more

... and 2 files with indirect coverage changes

@erri120 erri120 requested a review from Al12rs November 2, 2023 14:31
@halgari halgari merged commit b324e46 into Nexus-Mods:main Nov 2, 2023
6 checks passed
@erri120 erri120 deleted the issue-737-ui-docs branch November 2, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants