Add Colors and Fonts resources #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al12rs
reviewed
Oct 25, 2023
Al12rs
reviewed
Oct 25, 2023
Comment on lines
+15
to
+17
| <ResourceInclude x:Key="Colors" Source="avares://NexusMods.App.UI/Palatte/Colors.axaml"/> | ||
| <ResourceInclude x:Key="Fonts" Source="avares://NexusMods.App.UI/Palatte/Fonts.axaml"/> | ||
|
|
There was a problem hiding this comment.
The idea is that we have everything in a single file (Nexus.xaml) that then references the rest.
We want to be able to swap out one file and get a completely different styling for the app.
Is that possible?
There was a problem hiding this comment.
You can just load a different resource file later and it will overwrite the previous values.
Codecov Report
@@ Coverage Diff @@
## main #736 +/- ##
==========================================
+ Coverage 63.26% 63.98% +0.71%
==========================================
Files 581 581
Lines 17796 17796
Branches 1247 1247
==========================================
+ Hits 11259 11386 +127
+ Misses 6205 6088 -117
+ Partials 332 322 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
halgari
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #735.