Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Standard Button" using Control Themes #734

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Oct 25, 2023

This was mostly an experiment to see how well the new Control Themes work in Avalonia.

Part of #735

2023-10-25_14-15-24

@erri120 erri120 added the Design UI/UX This is related to the UI. label Oct 25, 2023
@erri120 erri120 requested a review from a team October 25, 2023 12:17
@erri120 erri120 self-assigned this Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #734 (94fe16f) into main (6df4e16) will increase coverage by 64.07%.
Report is 19 commits behind head on main.
The diff coverage is 3.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #734       +/-   ##
=========================================
+ Coverage      0   64.07%   +64.07%     
=========================================
  Files         0      581      +581     
  Lines         0    17796    +17796     
  Branches      0     1247     +1247     
=========================================
+ Hits          0    11402    +11402     
- Misses        0     6073     +6073     
- Partials      0      321      +321     
Flag Coverage Δ
Linux 63.36% <3.57%> (?)
Windows 63.16% <3.57%> (?)
clean_environment_tests 64.05% <3.57%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/NexusMods.App.UI/Palatte/Nexus.xaml 99.20% <100.00%> (ø)
src/NexusMods.App.UI/Icons/IconTypeConverter.cs 0.00% <0.00%> (ø)
...exusMods.App.UI/Controls/Buttons/StandardButton.cs 0.00% <0.00%> (ø)
...c/NexusMods.App.UI/Converters/TextCaseConverter.cs 0.00% <0.00%> (ø)

... and 577 files with indirect coverage changes

@erri120 erri120 mentioned this pull request Oct 25, 2023
10 tasks
@erri120 erri120 merged commit de31432 into Nexus-Mods:main Oct 25, 2023
6 checks passed
@erri120 erri120 deleted the button-controlthemes branch October 25, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design UI/UX This is related to the UI.
2 participants