Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace pages and persistence #731

Merged
merged 18 commits into from
Oct 25, 2023

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Oct 23, 2023

Part of #674.

@erri120 erri120 added this to the v0.3 milestone Oct 23, 2023
@erri120 erri120 self-assigned this Oct 23, 2023
@erri120 erri120 mentioned this pull request Oct 24, 2023
45 tasks
@erri120 erri120 changed the title WIP: Workspace pages and persistence Oct 24, 2023
@erri120 erri120 requested a review from a team October 24, 2023 12:56
@erri120 erri120 marked this pull request as ready for review October 24, 2023 12:56
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #731 (d0a9ff1) into main (4b9aabc) will increase coverage by 64.16%.
Report is 2 commits behind head on main.
The diff coverage is 9.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #731       +/-   ##
=========================================
+ Coverage      0   64.16%   +64.16%     
=========================================
  Files         0      578      +578     
  Lines         0    17740    +17740     
  Branches      0     1242     +1242     
=========================================
+ Hits          0    11383    +11383     
- Misses        0     6035     +6035     
- Partials      0      322      +322     
Flag Coverage Δ
Linux 63.37% <9.75%> (?)
Windows 63.36% <9.75%> (?)
clean_environment_tests 64.14% <9.75%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/NexusMods.App.UI/InjectedViewLocator.cs 67.74% <100.00%> (ø)
...p.UI/LeftMenu/Items/LaunchButtonDesignViewModel.cs 48.00% <ø> (ø)
...ods.App.UI/LeftMenu/Items/LaunchButtonViewModel.cs 42.85% <ø> (ø)
src/NexusMods.App.UI/Services.cs 98.38% <100.00%> (ø)
src/NexusMods.App.UI/Startup.cs 85.71% <ø> (ø)
src/NexusMods.App.UI/TypeFinder.cs 100.00% <100.00%> (ø)
...rc/NexusMods.App.UI/Windows/MainWindowViewModel.cs 72.22% <ø> (ø)
...em/PanelTabHeader/PanelTabHeaderDesignViewModel.cs 0.00% <ø> (ø)
.../NexusMods.App.UI/Controls/Dummy/DummyViewModel.cs 0.00% <0.00%> (ø)
src/NexusMods.App/Program.cs 0.00% <0.00%> (ø)
... and 23 more

... and 545 files with indirect coverage changes

@Al12rs Al12rs self-requested a review October 24, 2023 15:06
@erri120 erri120 requested a review from Al12rs October 25, 2023 09:05
@Al12rs Al12rs merged commit 75ad627 into Nexus-Mods:main Oct 25, 2023
7 checks passed
@erri120 erri120 deleted the issue-674-panels-part-4 branch October 25, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants