Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish for FOMOD UI #726

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Polish for FOMOD UI #726

merged 1 commit into from
Oct 25, 2023

Conversation

Patriot99
Copy link
Contributor

#600

Language.pl.resx.

Polish UI for FOMOD.

Polish Language.pl.resx.
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #726 (764313b) into main (4b9aabc) will increase coverage by 64.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #726       +/-   ##
=========================================
+ Coverage      0   64.96%   +64.96%     
=========================================
  Files         0      558      +558     
  Lines         0    17467    +17467     
  Branches      0     1225     +1225     
=========================================
+ Hits          0    11348    +11348     
- Misses        0     5796     +5796     
- Partials      0      323      +323     
Flag Coverage Δ
Linux 64.20% <ø> (?)
Windows 64.16% <ø> (?)
clean_environment_tests 64.95% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 558 files with indirect coverage changes

Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.


Note:

The original English localization uses 'Next' [Następny] and 'Previous' [Poprzedni]; which is more formal/robotic.

The PR uses the words Dalej [onward/proceed] and Wstecz [back(wards)], which are more informal and commonly found on install wizards (thus within user expectation). Since the FOMOD installer is effectively an install wizard, I think it's more appropriate to use what is in this PR.

In that vein, I'm wondering if we should change the English locale to say 'Back' instead of 'Previous'. It 'feels' more user friendly, so I figured I'd ask @captainsandypants

@Patriot99
Copy link
Contributor Author

I will add from myself:
For me, Back (Wstecz) is more suitable than Previous (Poprzedni). I also took into account that this is an installation wizard where you usually see Back (Wstecz) and Next (Dalej) rather than Previous (Poprzedni). When translating, I change the words that fit in Polish, rather than literally translating a word from English to Polish. A normal user will not check the source code, but only what he sees at the moment. It's all about good word choice and making sure everything is understandable. I know from experience that people will complain if the word does not fit in a particular place.

@captainsandypants
Copy link
Collaborator

This all makes sense, happy to change.

@halgari halgari merged commit fb577cb into Nexus-Mods:main Oct 25, 2023
5 of 6 checks passed
@Patriot99 Patriot99 deleted the patch-1 branch October 25, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants