Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the Loadout Synchronizer #697

Merged
merged 33 commits into from
Oct 11, 2023
Merged

Conversation

halgari
Copy link
Collaborator

@halgari halgari commented Oct 5, 2023

Implementation of the structure and tests of #626. This does not convert exsting games over to the new syncronizer, that will be done in a future pull request. All of the code is in the ALoadoutSyncronizer, start there or in ALoadoutSyncronizerTests to see usage.

@halgari halgari linked an issue Oct 5, 2023 that may be closed by this pull request
@halgari halgari self-assigned this Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

This PR conflicts with main. You need to rebase the PR before it can be merged.

# Conflicts:
#	src/NexusMods.DataModel/Games/AGame.cs
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #697 (4867557) into main (37c4ab0) will increase coverage by 64.39%.
Report is 14 commits behind head on main.
The diff coverage is 87.60%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #697       +/-   ##
=========================================
+ Coverage      0   64.39%   +64.39%     
=========================================
  Files         0      656      +656     
  Lines         0    19205    +19205     
  Branches      0     1259     +1259     
=========================================
+ Hits          0    12368    +12368     
- Misses        0     6511     +6511     
- Partials      0      326      +326     
Flag Coverage Δ
Linux 63.81% <87.60%> (?)
Windows 63.50% <87.60%> (?)
clean_environment_tests 64.38% <87.60%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...xusMods.DataModel/Abstractions/EntityDictionary.cs 85.18% <100.00%> (ø)
...taModel/LoadoutSynchronizer/DefaultSynchronizer.cs 100.00% <100.00%> (ø)
...exusMods.DataModel/LoadoutSynchronizer/FileTree.cs 100.00% <100.00%> (ø)
....DataModel/LoadoutSynchronizer/FlattenedLoadout.cs 100.00% <100.00%> (ø)
...rc/NexusMods.DataModel/Loadouts/LoadoutRegistry.cs 75.00% <100.00%> (ø)
...NexusMods.DataModel/Loadouts/LoadoutSyncronizer.cs 95.88% <100.00%> (ø)
...usMods.DataModel/Loadouts/Markers/LoadoutMarker.cs 60.00% <100.00%> (ø)
src/NexusMods.DataModel/Loadouts/Mods/Mod.cs 100.00% <ø> (ø)
src/NexusMods.DataModel/Services.cs 96.77% <100.00%> (ø)
src/NexusMods.DataModel/Sorting/Rules/After.cs 100.00% <100.00%> (ø)
... and 17 more

... and 629 files with indirect coverage changes

@halgari halgari requested a review from a team October 9, 2023 20:42
@Al12rs
Copy link
Contributor

Al12rs commented Oct 10, 2023

Can I have a look before merging?

continue;
}

continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Unreachable, can be removed

@halgari halgari merged commit 0c3d792 into main Oct 11, 2023
7 checks passed
@halgari halgari deleted the 626-wip-rework-the-loadout-syncronizer branch October 11, 2023 13:34
@erri120 erri120 mentioned this pull request Oct 12, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants