-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the Loadout Synchronizer #697
Conversation
# Conflicts: # tests/NexusMods.StandardGameLocators.TestHelpers/StubbedGames/StubbedGame.cs
This PR conflicts with |
# Conflicts: # src/NexusMods.DataModel/Games/AGame.cs
This PR doesn't conflict with |
Codecov Report
@@ Coverage Diff @@
## main #697 +/- ##
=========================================
+ Coverage 0 64.39% +64.39%
=========================================
Files 0 656 +656
Lines 0 19205 +19205
Branches 0 1259 +1259
=========================================
+ Hits 0 12368 +12368
- Misses 0 6511 +6511
- Partials 0 326 +326
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/NexusMods.DataModel/LoadoutSynchronizer/DiskModificationPlan.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.DataModel/LoadoutSynchronizer/ALoadoutSynchronizer.cs
Outdated
Show resolved
Hide resolved
Can I have a look before merging? |
continue; | ||
} | ||
|
||
continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is Unreachable, can be removed
Implementation of the structure and tests of #626. This does not convert exsting games over to the new syncronizer, that will be done in a future pull request. All of the code is in the ALoadoutSyncronizer, start there or in ALoadoutSyncronizerTests to see usage.