Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set your own game version in AGame #684

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

Aragas
Copy link
Contributor

@Aragas Aragas commented Sep 30, 2023

To have the same functionality, you have to override AGame.Installations with copying the AGame.GetInstallations() method

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #684 (f8dcf60) into main (ec242b2) will increase coverage by 64.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #684       +/-   ##
=========================================
+ Coverage      0   64.53%   +64.53%     
=========================================
  Files         0      633      +633     
  Lines         0    18145    +18145     
  Branches      0     1176     +1176     
=========================================
+ Hits          0    11709    +11709     
- Misses        0     6134     +6134     
- Partials      0      302      +302     
Flag Coverage Δ
Linux 63.84% <ø> (?)
Windows 63.75% <ø> (?)
clean_environment_tests 64.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/NexusMods.DataModel/Games/AGame.cs 65.11% <ø> (ø)

... and 632 files with indirect coverage changes

@halgari halgari merged commit 43a65de into Nexus-Mods:main Sep 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants