Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run games through Steam #681

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Sep 27, 2023

Resolves #152.

@erri120 erri120 added this to the v0.3 milestone Sep 27, 2023
@erri120 erri120 requested a review from a team September 27, 2023 14:38
@erri120 erri120 self-assigned this Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #681 (31b9502) into main (fd39fed) will decrease coverage by 0.18%.
The diff coverage is 24.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
- Coverage   64.50%   64.32%   -0.18%     
==========================================
  Files         633      633              
  Lines       18006    18054      +48     
  Branches     1161     1172      +11     
==========================================
- Hits        11615    11614       -1     
- Misses       6092     6142      +50     
+ Partials      299      298       -1     
Flag Coverage Δ
Linux 63.59% <24.70%> (-0.24%) ⬇️
Windows 63.52% <24.70%> (-0.11%) ⬇️
clean_environment_tests 64.30% <24.70%> (-0.19%) ⬇️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...LegendaryEdition/SkyrimLegendaryEditionGameTool.cs 50.00% <100.00%> (ø)
...yrimSpecialEdition/SkyrimSpecialEditionGameTool.cs 50.00% <100.00%> (ø)
...king/NexusMods.Networking.NexusWebApi.NMA/OAuth.cs 98.88% <ø> (ø)
...Networking.NexusWebApi/DTOs/OAuth/JwtTokenReply.cs 100.00% <100.00%> (ø)
src/NexusMods.DataModel/Games/AGame.cs 65.11% <100.00%> (-1.56%) ⬇️
src/NexusMods.DataModel/Games/GameInstallation.cs 83.33% <100.00%> (+1.51%) ⬆️
...ods.App.UI/LeftMenu/Items/LaunchButtonViewModel.cs 42.85% <0.00%> (-1.59%) ⬇️
...s.BethesdaGameStudios/RunGameWithScriptExtender.cs 16.66% <33.33%> (ø)
...xusMods.Networking.NexusWebApi.NMA/LoginManager.cs 61.01% <50.00%> (+5.08%) ⬆️
...Networking.NexusWebApi.NMA/OAuth2MessageFactory.cs 32.75% <0.00%> (ø)
... and 2 more

... and 6 files with indirect coverage changes

Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly for merging, there's only 1 note I have for potential bug.

Basic case of running main game binary is covered here, and most advanced required cases are already present as checkboxes in:

So that's a 👍

Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

Not sure how the OAuth stuff got here, maybe you committed to wrong branch. If it's a mistake, just fix it up before merging :p

@halgari halgari merged commit a74a37b into Nexus-Mods:main Sep 28, 2023
4 of 6 checks passed
@erri120 erri120 deleted the issue-152-run-steam branch September 28, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants