-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run games through Steam #681
Conversation
Codecov Report
@@ Coverage Diff @@
## main #681 +/- ##
==========================================
- Coverage 64.50% 64.32% -0.18%
==========================================
Files 633 633
Lines 18006 18054 +48
Branches 1161 1172 +11
==========================================
- Hits 11615 11614 -1
- Misses 6092 6142 +50
+ Partials 299 298 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly for merging, there's only 1 note I have for potential bug.
Basic case of running main game binary is covered here, and most advanced required cases are already present as checkboxes in:
So that's a 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
Not sure how the OAuth stuff got here, maybe you committed to wrong branch. If it's a mistake, just fix it up before merging :p
Resolves #152.