-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: Basic Suggesions for AdvancedInstaller #667
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…suggestions-for-advancedinstaller
…suggestions-for-advancedinstaller
…suggestions-for-advancedinstaller
Codecov Report
@@ Coverage Diff @@
## main #667 +/- ##
==========================================
+ Coverage 64.19% 64.64% +0.45%
==========================================
Files 624 631 +7
Lines 17569 17903 +334
Branches 1131 1152 +21
==========================================
+ Hits 11279 11574 +295
- Misses 6011 6040 +29
- Partials 279 289 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Al12rs
reviewed
Sep 26, 2023
...ds.DataModel/Games/GameCapabilities/FolderMatchInstallerCapability/IModInstallDestination.cs
Outdated
Show resolved
Hide resolved
Al12rs
reviewed
Sep 26, 2023
...ds.DataModel/Games/GameCapabilities/FolderMatchInstallerCapability/IModInstallDestination.cs
Outdated
Show resolved
Hide resolved
Al12rs
reviewed
Sep 26, 2023
...sMods.DataModel/Games/GameCapabilities/FolderMatchInstallerCapability/InstallFolderTarget.cs
Show resolved
Hide resolved
Things look good, just have the two questions above |
Al12rs
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR'ing the remaining work from last week.
All details available in:
ADR has been updated accordingly for this PR.