Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Basic Suggesions for AdvancedInstaller #667

Merged
merged 9 commits into from
Sep 27, 2023

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Sep 25, 2023

PR'ing the remaining work from last week.

All details available in:

ADR has been updated accordingly for this PR.

@Sewer56 Sewer56 self-assigned this Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #667 (724be11) into main (2b8fd5d) will increase coverage by 0.45%.
Report is 5 commits behind head on main.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
+ Coverage   64.19%   64.64%   +0.45%     
==========================================
  Files         624      631       +7     
  Lines       17569    17903     +334     
  Branches     1131     1152      +21     
==========================================
+ Hits        11279    11574     +295     
- Misses       6011     6040      +29     
- Partials      279      289      +10     
Flag Coverage Δ
Linux 63.90% <96.77%> (+0.37%) ⬆️
Windows 63.81% <96.77%> (+0.38%) ⬆️
clean_environment_tests 64.62% <96.77%> (+0.43%) ⬆️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...xusMods.Games.BethesdaGameStudios/ABethesdaGame.cs 100.00% <100.00%> (ø)
...s/NexusMods.Games.DarkestDungeon/DarkestDungeon.cs 59.61% <100.00%> (+0.79%) ⬆️
...c/Games/NexusMods.Games.RedEngine/Cyberpunk2077.cs 89.47% <100.00%> (+0.28%) ⬆️
src/Games/NexusMods.Games.Sifu/Sifu.cs 78.94% <100.00%> (+1.16%) ⬆️
...mes/NexusMods.Games.StardewValley/StardewValley.cs 68.88% <100.00%> (+0.70%) ⬆️
src/NexusMods.DataModel/Games/AGame.cs 66.66% <100.00%> (+5.12%) ⬆️
...MatchInstallerCapability/IModInstallDestination.cs 100.00% <100.00%> (ø)
...derMatchInstallerCapability/InstallFolderTarget.cs 100.00% <ø> (ø)
src/NexusMods.DataModel/Games/GameInstallation.cs 81.81% <100.00%> (+1.81%) ⬆️
...c/NexusMods.DataModel/Games/Unknown/UnknownGame.cs 0.00% <0.00%> (ø)
... and 1 more

... and 19 files with indirect coverage changes

@Sewer56 Sewer56 requested a review from a team September 26, 2023 01:05
@Al12rs
Copy link
Contributor

Al12rs commented Sep 26, 2023

Things look good, just have the two questions above

@Al12rs Al12rs merged commit 9b34405 into main Sep 27, 2023
6 checks passed
@Al12rs Al12rs deleted the suggestions-for-advancedinstaller branch September 27, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants