Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Base Implementation of AdvancedInstaller Core #657

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Sep 20, 2023

This PR implements the core/base of AdvancedInstaller; checklist and more details available here:

The only thing not done is the mechanism that causes AdvancedInstaller to be invoked.

The AdvancedInstaller IModInstaller is currently a stub. We decided that we still need to discuss with design how the Advanced Installer is to be invoked (e.g. should it be invoked if all other installers don't perform an operation? Should we prompt the user? etc.).

Thus the activation logic is not included in this PR.

@Sewer56 Sewer56 requested a review from a team September 20, 2023 14:32
@Sewer56 Sewer56 self-assigned this Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #657 (842dc5a) into main (03a3480) will increase coverage by 0.00%.
The diff coverage is 73.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #657   +/-   ##
=======================================
  Coverage   64.04%   64.05%           
=======================================
  Files         617      622    +5     
  Lines       17401    17472   +71     
  Branches     1115     1120    +5     
=======================================
+ Hits        11144    11191   +47     
- Misses       5978     6002   +24     
  Partials      279      279           
Flag Coverage Δ
Linux 63.36% <73.23%> (+0.10%) ⬆️
Windows 63.24% <73.23%> (-0.01%) ⬇️
clean_environment_tests 64.03% <73.23%> (+<0.01%) ⬆️
network_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
...sMods.Games.AdvancedInstaller/AdvancedInstaller.cs 0.00%
...vancedInstaller/Exceptions/MappingAlreadyExists.cs 66.66%
...exusMods.Games.AdvancedInstaller/DeploymentData.cs 94.44%
...ames.AdvancedInstaller/DeploymentDataExtensions.cs 100.00%
.../NexusMods.Games.AdvancedInstaller/ThrowHelpers.cs 100.00%
@Sewer56 Sewer56 merged commit 68544d9 into main Sep 20, 2023
7 checks passed
@erri120 erri120 deleted the advanced-installer-2 branch October 2, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants